Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 436513002: MacViews: Fix app list demo, for Widget InitParams "context" type change (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, mac-views-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix app list demo, for Widget InitParams "context" type change "context" changed from a NativeView to a NativeWindow in r283126. This gets app_list_demo up to speed. BUG=365977, 399191 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287290

Patch Set 1 #

Patch Set 2 : fix CrOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M ui/app_list/demo/app_list_demo_views.cc View 1 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tapted
6 years, 4 months ago (2014-07-31 08:21:34 UTC) #1
calamity
lgtm
6 years, 4 months ago (2014-08-04 02:27:28 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-08-04 02:35:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/436513002/20001
6 years, 4 months ago (2014-08-04 02:35:47 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 03:35:46 UTC) #5
Message was sent while issue was closed.
Change committed as 287290

Powered by Google App Engine
This is Rietveld 408576698