Moved CreateNativeAppWindow from AppWindow::Delegate to AppsClient.

Moved CreateNativeAppWindow from AppWindow::Delegate to AppsClient.

This refactor deletes AppWindow::Delegate, to simplify the arrangement
of classes relating to AppWindow. AppsClient has been moved from apps to
apps/ui, and ChromeAppsClient has been moved from chrome/browser/apps to
chrome/browser/ui/apps, for DEPS reasons.

This is a follow-up to r286514, which saw the rest of
AppWindow::Delegate's methods moved into another class.

BUG=391137
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287469

[Matt Giuca, 2014-07-31 03:24:54]

I think this is what you want. Please advise (and I will get reviewers for the
handful of files you don't OWN after that).

It's a pretty huge number of files changed but mostly just updating references.
More importantly, do the DEPS make sense? Is it okay to have AppsClient in
apps/ui and ChromeAppsClient in chrome/browser/ui/apps?

[benwells, 2014-07-31 06:23:41]

lgtm

https://codereview.chromium.org/436503002/diff/1/chrome/browser/ui/apps/chrom...
File chrome/browser/ui/apps/chrome_apps_client.h (right):

https://codereview.chromium.org/436503002/diff/1/chrome/browser/ui/apps/chrom...
chrome/browser/ui/apps/chrome_apps_client.h:13: struct DefaultSingletonTraits;
Did git cl format change this?

[benwells, 2014-07-31 06:23:42]

lgtm

[Matt Giuca, 2014-07-31 07:13:38]

https://codereview.chromium.org/436503002/diff/1/chrome/browser/ui/apps/chrom...
File chrome/browser/ui/apps/chrome_apps_client.h (right):

https://codereview.chromium.org/436503002/diff/1/chrome/browser/ui/apps/chrom...
chrome/browser/ui/apps/chrome_apps_client.h:13: struct DefaultSingletonTraits;
Yes.

(And I was forced to run it, since I renamed the file.)

[Matt Giuca, 2014-08-01 03:39:18]

+sky, TBR for browser_process_impl.cc and testing_browser_process.cc (update
include for renamed header file).

[Matt Giuca, 2014-08-01 03:39:25]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-01 03:41:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/436503002/1

[commit-bot: I haz the power, 2014-08-01 08:17:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/36308)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/41345)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-01 08:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-01 08:21:41]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Matt Giuca, 2014-08-04 06:32:56]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-04 06:33:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/436503002/60001

[Matt Giuca, 2014-08-04 06:52:42]

The CQ bit was unchecked by mgiuca@chromium.org

[Matt Giuca, 2014-08-04 06:54:17]

sky, additional TBR for chrome_launcher_controller_unittest.cc (in addition to
browser_process_impl.cc and testing_browser_process.cc).

[Matt Giuca, 2014-08-04 06:54:28]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-04 06:55:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/436503002/80001

[commit-bot: I haz the power, 2014-08-04 12:58:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-04 13:01:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-04 13:01:23]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2014-08-05 00:02:53]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-05 00:04:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/436503002/80001

[commit-bot: I haz the power, 2014-08-05 00:09:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-05 00:14:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 00:14:54]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2014-08-05 01:51:34]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-05 01:53:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/436503002/100001

[commit-bot: I haz the power, 2014-08-05 04:58:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-05 05:35:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 05:35:11]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2014-08-05 05:59:28]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-08-05 06:01:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mgiuca@chromium.org/436503002/100001

[commit-bot: I haz the power, 2014-08-05 06:38:28]

Change committed as 287469