Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 436483002: Fix a few more -Wreorder warnings. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fix a few more -Wreorder warnings. No intended behavior change. BUG=pdfium:29 R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/09363c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -29 lines) Patch
M core/src/fpdfdoc/doc_vt.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/include/javascript/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 2 chunks +9 lines, -4 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_list.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Note.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 4 months ago (2014-07-31 02:42:59 UTC) #1
Bo Xu
On 2014/07/31 02:42:59, Nico (away) wrote: lgtm
6 years, 4 months ago (2014-07-31 17:04:57 UTC) #2
Nico
6 years, 4 months ago (2014-07-31 17:07:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r09363c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698