tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py - Issue 436453002: Remove page_measurement_results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

Issue 436453002: Remove page_measurement_results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

index 6ac8f77278350b39efb2ce8da5fa1eefd8eaacd4..cb4f07786f33f7a830a35f88af93ec350fb4032b 100644

--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py

@@ -11,7 +11,7 @@ from telemetry.page import page as page_module

from telemetry.page import page_measurement_unittest_base

from telemetry.page import page_set

from telemetry.page import page as page_module

-from telemetry.results import page_measurement_results

+from telemetry.results import page_test_results

from telemetry.timeline import async_slice

from telemetry.timeline import model as model_module

from telemetry.unittest import options_for_unittests

@@ -68,7 +68,7 @@ class TimelineBasedMetricTestData(object):

renderer_process = self._model.GetOrCreateProcess(1)

self._renderer_thread = renderer_process.GetOrCreateThread(2)

self._renderer_thread.name = 'CrRendererMain'

- self._results = page_measurement_results.PageMeasurementResults()

+ self._results = page_test_results.PageTestResults()

self._metric = None

self._ps = None

« tools/perf/metrics/test_page_measurement_results.py ('K') | « tools/telemetry/telemetry/web_perf/metrics/fast_metric_unittest.py ('k') | no next file » | no next file with comments »