Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py

Issue 436453002: Remove page_measurement_results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py
index 455ffbc56d1daf8deef5ee6a24bb2e2430f30cdd..855bd6b71a2ba1868186552fa341671f76292761 100644
--- a/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py
+++ b/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py
@@ -20,10 +20,10 @@ def _MakePageSet():
ps.AddPageWithDefaultRunNavigate('http://www.baz.com/')
return ps
-class SummarySavingPageMeasurementResults(
+class SummarySavingPageTestResults(
buildbot_page_measurement_results.BuildbotPageMeasurementResults):
def __init__(self, trace_tag=''):
- super(SummarySavingPageMeasurementResults, self).__init__(
+ super(SummarySavingPageTestResults, self).__init__(
None, trace_tag=trace_tag)
self.results = []
@@ -36,7 +36,7 @@ class BuildbotPageMeasurementResultsTest(
def test_basic_summary(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.StartTest(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
@@ -63,7 +63,7 @@ class BuildbotPageMeasurementResultsTest(
def test_basic_summary_with_only_one_page(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.StartTest(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
@@ -81,7 +81,7 @@ class BuildbotPageMeasurementResultsTest(
def test_basic_summary_nonuniform_results(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.StartTest(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
@@ -124,7 +124,7 @@ class BuildbotPageMeasurementResultsTest(
"""If a page failed, only print summary for individual pages."""
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.StartTest(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
@@ -151,7 +151,7 @@ class BuildbotPageMeasurementResultsTest(
"""Page fails on one iteration, no averaged results should print."""
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.StartTest(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
@@ -192,7 +192,7 @@ class BuildbotPageMeasurementResultsTest(
def test_repeated_pageset(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.StartTest(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
@@ -237,7 +237,7 @@ class BuildbotPageMeasurementResultsTest(
def test_repeated_pages(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.StartTest(test_page_set.pages[0])
measurement_results.AddValue(scalar.ScalarValue(
test_page_set.pages[0], 'a', 'seconds', 3))
@@ -282,7 +282,7 @@ class BuildbotPageMeasurementResultsTest(
def test_overall_results_trace_tag(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults(trace_tag='_ref')
+ measurement_results = SummarySavingPageTestResults(trace_tag='_ref')
measurement_results.AddSummaryValue(
scalar.ScalarValue(None, 'a', 'seconds', 1))
@@ -317,7 +317,7 @@ class BuildbotPageMeasurementResultsTest(
def test_overall_results_page_runs_twice(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.AddSummaryValue(
scalar.ScalarValue(None, 'a', 'seconds', 1))
@@ -349,7 +349,7 @@ class BuildbotPageMeasurementResultsTest(
def test_unimportant_results(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.AddSummaryValue(
scalar.ScalarValue(None, 'a', 'seconds', 1, important=False))
@@ -381,7 +381,7 @@ class BuildbotPageMeasurementResultsTest(
def test_list_value(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.AddSummaryValue(
list_of_scalar_values.ListOfScalarValues(None, 'a', 'seconds', [1, 1]))
@@ -415,7 +415,7 @@ class BuildbotPageMeasurementResultsTest(
def test_histogram(self):
test_page_set = _MakePageSet()
- measurement_results = SummarySavingPageMeasurementResults()
+ measurement_results = SummarySavingPageTestResults()
measurement_results.StartTest(test_page_set.pages[0])
measurement_results.AddValue(histogram.HistogramValue(
test_page_set.pages[0], 'a', 'units',

Powered by Google App Engine
This is Rietveld 408576698