Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 436453002: Remove page_measurement_results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/record_wpr.py
diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py
index 92cdad90106f61baca84b94bfdc67b4e1fc1ef7f..f394d41eebf16bdc592c169ca8e54d655798fc48 100755
--- a/tools/telemetry/telemetry/page/record_wpr.py
+++ b/tools/telemetry/telemetry/page/record_wpr.py
@@ -16,7 +16,6 @@ from telemetry.page import page_set
from telemetry.page import page_test
from telemetry.page import profile_creator
from telemetry.page import test_expectations
-from telemetry.results import page_measurement_results
class RecorderPageTest(page_test.PageTest): # pylint: disable=W0223
@@ -61,14 +60,9 @@ class RecorderPageTest(page_test.PageTest): # pylint: disable=W0223
# speed index metric.
time.sleep(3)
- # When running record_wpr, results is a GTestTestResults, so we create a
- # dummy PageMeasurementResults that implements the functions we use.
- # TODO(chrishenry): Fix the need for a dummy_results object.
- dummy_results = page_measurement_results.PageMeasurementResults()
-
if self.page_test:
self._action_name_to_run = self.page_test.action_name_to_run
- self.page_test.RunPage(page, tab, dummy_results)
+ self.page_test.RunPage(page, tab, results)
return
should_reload = False
@@ -81,7 +75,7 @@ class RecorderPageTest(page_test.PageTest): # pylint: disable=W0223
if should_reload:
self.RunNavigateSteps(page, tab)
self._action_name_to_run = action_name
- super(RecorderPageTest, self).RunPage(page, tab, dummy_results)
+ super(RecorderPageTest, self).RunPage(page, tab, results)
should_reload = True
def RunNavigateSteps(self, page, tab):

Powered by Google App Engine
This is Rietveld 408576698