tools/perf/metrics/__init__.py - Issue 436453002: Remove page_measurement_results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/metrics/init.py

Issue 436453002: Remove page_measurement_results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase again Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/metrics/__init__.py

diff --git a/tools/perf/metrics/__init__.py b/tools/perf/metrics/__init__.py

index 3066ce90f0e6e7242351a1a791cc9c8324a4de8d..67c4def44cdfc0976a0a7c43e7f3a1cf7abd231a 100644

--- a/tools/perf/metrics/__init__.py

+++ b/tools/perf/metrics/__init__.py

@@ -35,7 +35,7 @@ class Metric(object):

"""Add the data collected into the results object for a measurement.

Metrics may implement AddResults to provide a common way to add results

- to the PageMeasurementResults in PageMeasurement.AddMeasurement --

+ to the PageTestResults in PageMeasurement.AddMeasurement --

results should be added with results.AddValue(...).

"""

raise NotImplementedError()