Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: tools/telemetry/telemetry/results/page_measurement_results_unittest.py

Issue 436453002: Remove page_measurement_results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase again Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/page_measurement_results_unittest.py
deleted file mode 100644
index 4ce1b8ed47cd864a013574be2e6a747014f4944a..0000000000000000000000000000000000000000
--- a/tools/telemetry/telemetry/results/page_measurement_results_unittest.py
+++ /dev/null
@@ -1,171 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-import os
-import unittest
-
-from telemetry import perf_tests_helper
-from telemetry.page import page_set
-from telemetry.results import page_measurement_results
-from telemetry.value import failure
-from telemetry.value import histogram
-from telemetry.value import scalar
-
-
-def _MakePageSet():
- ps = page_set.PageSet(file_path=os.path.dirname(__file__))
- ps.AddPageWithDefaultRunNavigate("http://www.bar.com/")
- ps.AddPageWithDefaultRunNavigate("http://www.baz.com/")
- ps.AddPageWithDefaultRunNavigate("http://www.foo.com/")
- return ps
-
-class NonPrintingPageMeasurementResults(
- page_measurement_results.PageMeasurementResults):
- def __init__(self):
- super(NonPrintingPageMeasurementResults, self).__init__()
-
- def _PrintPerfResult(self, *args):
- pass
-
-class SummarySavingPageMeasurementResults(
- page_measurement_results.PageMeasurementResults):
- def __init__(self):
- super(SummarySavingPageMeasurementResults, self).__init__()
- self.results = []
-
- def _PrintPerfResult(self, *args):
- res = perf_tests_helper.PrintPerfResult(*args, print_to_stdout=False)
- self.results.append(res)
-
-class PageMeasurementResultsTest(unittest.TestCase):
- def setUp(self):
- self._page_set = _MakePageSet()
-
- @property
- def pages(self):
- return self._page_set.pages
-
- def test_basic(self):
- results = NonPrintingPageMeasurementResults()
- results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
- results.DidRunPage(self.pages[0])
-
- results.WillRunPage(self.pages[1])
- results.AddValue(scalar.ScalarValue(self.pages[1], 'a', 'seconds', 3))
- results.DidRunPage(self.pages[1])
-
- results.PrintSummary()
-
- values = results.FindPageSpecificValuesForPage(self.pages[0], 'a')
- self.assertEquals(1, len(values))
- v = values[0]
- self.assertEquals(v.name, 'a')
- self.assertEquals(v.page, self.pages[0])
-
- values = results.FindAllPageSpecificValuesNamed('a')
- assert len(values) == 2
-
- def test_url_is_invalid_value(self):
- results = NonPrintingPageMeasurementResults()
- results.WillRunPage(self.pages[0])
- self.assertRaises(
- AssertionError,
- lambda: results.AddValue(scalar.ScalarValue(
- self.pages[0], 'url', 'string', 'foo')))
-
- def test_add_summary_value_with_page_specified(self):
- results = NonPrintingPageMeasurementResults()
- results.WillRunPage(self.pages[0])
- self.assertRaises(
- AssertionError,
- lambda: results.AddSummaryValue(scalar.ScalarValue(self.pages[0],
- 'a', 'units', 3)))
-
- def test_unit_change(self):
- results = NonPrintingPageMeasurementResults()
- results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
- results.DidRunPage(self.pages[0])
-
- results.WillRunPage(self.pages[1])
- self.assertRaises(
- AssertionError,
- lambda: results.AddValue(scalar.ScalarValue(
- self.pages[1], 'a', 'foobgrobbers', 3)))
-
- def test_type_change(self):
- results = NonPrintingPageMeasurementResults()
- results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
- results.DidRunPage(self.pages[0])
-
- results.WillRunPage(self.pages[1])
- self.assertRaises(
- AssertionError,
- lambda: results.AddValue(histogram.HistogramValue(
- self.pages[1], 'a', 'seconds',
- raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}')))
-
- def test_basic_summary_all_pages_fail(self):
- """If all pages fail, no summary is printed."""
- results = SummarySavingPageMeasurementResults()
- results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
- results.AddValue(failure.FailureValue.FromMessage(self.pages[0], 'message'))
- results.DidRunPage(self.pages[0])
-
- results.WillRunPage(self.pages[1])
- results.AddValue(scalar.ScalarValue(self.pages[1], 'a', 'seconds', 7))
- results.AddValue(failure.FailureValue.FromMessage(self.pages[1], 'message'))
- results.DidRunPage(self.pages[1])
-
- results.PrintSummary()
- self.assertEquals(results.results, [])
-
- def test_get_successful_page_values_merged_no_failures(self):
- results = SummarySavingPageMeasurementResults()
- results.WillRunPage(self.pages[0])
- results.AddValue(scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3))
- self.assertEquals(1, len(results.all_page_specific_values))
- results.DidRunPage(self.pages[0])
-
- def test_get_all_values_for_successful_pages(self):
- results = SummarySavingPageMeasurementResults()
- results.WillRunPage(self.pages[0])
- value1 = scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3)
- results.AddValue(value1)
- results.DidRunPage(self.pages[0])
-
- results.WillRunPage(self.pages[1])
- value2 = scalar.ScalarValue(self.pages[1], 'a', 'seconds', 3)
- results.AddValue(value2)
- results.DidRunPage(self.pages[1])
-
- results.WillRunPage(self.pages[2])
- value3 = scalar.ScalarValue(self.pages[2], 'a', 'seconds', 3)
- results.AddValue(value3)
- results.DidRunPage(self.pages[2])
-
- self.assertEquals(
- [value1, value2, value3], results.all_page_specific_values)
-
- def test_get_all_values_for_successful_pages_one_page_fails(self):
- results = SummarySavingPageMeasurementResults()
- results.WillRunPage(self.pages[0])
- value1 = scalar.ScalarValue(self.pages[0], 'a', 'seconds', 3)
- results.AddValue(value1)
- results.DidRunPage(self.pages[0])
-
- results.WillRunPage(self.pages[1])
- value2 = failure.FailureValue.FromMessage(self.pages[1], 'Failure')
- results.AddValue(value2)
- results.DidRunPage(self.pages[1])
-
- results.WillRunPage(self.pages[2])
- value3 = scalar.ScalarValue(self.pages[2], 'a', 'seconds', 3)
- results.AddValue(value3)
- results.DidRunPage(self.pages[2])
-
- self.assertEquals(
- [value1, value2, value3], results.all_page_specific_values)

Powered by Google App Engine
This is Rietveld 408576698