Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/perf/metrics/test_page_measurement_results.py

Issue 436453002: Remove page_measurement_results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/metrics/test_page_measurement_results.py
diff --git a/tools/perf/metrics/test_page_measurement_results.py b/tools/perf/metrics/test_page_measurement_results.py
index 8d17e5b575771b8f6b1f404144869e582a967f2f..22774110be782b90747031f2dd27d8b1fb177763 100644
--- a/tools/perf/metrics/test_page_measurement_results.py
+++ b/tools/perf/metrics/test_page_measurement_results.py
@@ -3,14 +3,14 @@
# found in the LICENSE file.
from telemetry.page import page as page_module
-from telemetry.results import page_measurement_results
+from telemetry.results import page_test_results
from telemetry.value import scalar
-class TestPageMeasurementResults(
- page_measurement_results.PageMeasurementResults):
+class TestPageTestResults(
chrishenry 2014/07/31 05:01:12 Can we kill this class instead? Pretty please? Let
nednguyen 2014/07/31 14:24:51 I can do it a different patch. There maybe some th
chrishenry 2014/07/31 15:24:27 There might be indeed, but it shouldn't need a sub
+ page_test_results.PageTestResults):
def __init__(self, test):
- super(TestPageMeasurementResults, self).__init__()
+ super(TestPageTestResults, self).__init__()
self.test = test
page = page_module.Page("http://www.google.com", {})
self.StartTest(page)

Powered by Google App Engine
This is Rietveld 408576698