Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: tools/perf/metrics/test_page_measurement_results.py

Issue 436453002: Remove page_measurement_results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/metrics/__init__.py ('k') | tools/perf/metrics/timeline_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
chrishenry 2014/07/31 15:24:27 Btw I believe this is being used by chrome_proxy t
nednguyen 2014/07/31 15:44:52 Done. Renamed the file.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.page import page as page_module 5 from telemetry.page import page as page_module
6 from telemetry.results import page_measurement_results 6 from telemetry.results import page_test_results
7 from telemetry.value import scalar 7 from telemetry.value import scalar
8 8
9 9
10 class TestPageMeasurementResults( 10 class TestPageTestResults(
11 page_measurement_results.PageMeasurementResults): 11 page_test_results.PageTestResults):
12 def __init__(self, test): 12 def __init__(self, test):
13 super(TestPageMeasurementResults, self).__init__() 13 super(TestPageTestResults, self).__init__()
14 self.test = test 14 self.test = test
15 page = page_module.Page("http://www.google.com", {}) 15 page = page_module.Page("http://www.google.com", {})
16 self.StartTest(page) 16 self.StartTest(page)
17 17
18 def GetPageSpecificValueNamed(self, name): 18 def GetPageSpecificValueNamed(self, name):
19 values = [value for value in self.all_page_specific_values 19 values = [value for value in self.all_page_specific_values
20 if value.name == name] 20 if value.name == name]
21 assert len(values) == 1, 'Could not find value named %s' % name 21 assert len(values) == 1, 'Could not find value named %s' % name
22 return values[0] 22 return values[0]
23 23
24 def AssertHasPageSpecificScalarValue(self, name, units, expected_value): 24 def AssertHasPageSpecificScalarValue(self, name, units, expected_value):
25 value = self.GetPageSpecificValueNamed(name) 25 value = self.GetPageSpecificValueNamed(name)
26 self.test.assertEquals(units, value.units) 26 self.test.assertEquals(units, value.units)
27 self.test.assertTrue(isinstance(value, scalar.ScalarValue)) 27 self.test.assertTrue(isinstance(value, scalar.ScalarValue))
28 self.test.assertEquals(expected_value, value.value) 28 self.test.assertEquals(expected_value, value.value)
29 29
30 def __str__(self): 30 def __str__(self):
31 return '\n'.join([repr(x) for x in self.all_page_specific_values]) 31 return '\n'.join([repr(x) for x in self.all_page_specific_values])
OLDNEW
« no previous file with comments | « tools/perf/metrics/__init__.py ('k') | tools/perf/metrics/timeline_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698