Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: trunk/src/cc/trees/layer_tree_host_impl_unittest.cc

Issue 436413004: Revert 287325 because it breaks smoothness benchmarks on windows: "ValueError: LatencyInfo has no b… (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/cc/trees/layer_tree_host_impl.cc ('k') | trunk/src/cc/trees/layer_tree_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/cc/trees/layer_tree_host_impl_unittest.cc
===================================================================
--- trunk/src/cc/trees/layer_tree_host_impl_unittest.cc (revision 287455)
+++ trunk/src/cc/trees/layer_tree_host_impl_unittest.cc (working copy)
@@ -972,24 +972,6 @@
}
}
-TEST_F(LayerTreeHostImplTest, ScrollWithSwapPromises) {
- ui::LatencyInfo latency_info;
- latency_info.trace_id = 1234;
- scoped_ptr<SwapPromise> swap_promise(
- new LatencyInfoSwapPromise(latency_info));
-
- SetupScrollAndContentsLayers(gfx::Size(100, 100));
- EXPECT_EQ(InputHandler::ScrollStarted,
- host_impl_->ScrollBegin(gfx::Point(), InputHandler::Gesture));
- host_impl_->ScrollBy(gfx::Point(), gfx::Vector2d(0, 10));
- host_impl_->QueueSwapPromiseForMainThreadScrollUpdate(swap_promise.Pass());
- host_impl_->ScrollEnd();
-
- scoped_ptr<ScrollAndScaleSet> scroll_info = host_impl_->ProcessScrollDeltas();
- EXPECT_EQ(1u, scroll_info->swap_promises.size());
- EXPECT_EQ(latency_info.trace_id, scroll_info->swap_promises[0]->TraceId());
-}
-
TEST_F(LayerTreeHostImplTest, MasksToBoundsDoesntClobberInnerContainerSize) {
SetupScrollAndContentsLayers(gfx::Size(100, 100));
host_impl_->SetViewportSize(gfx::Size(50, 50));
@@ -6385,12 +6367,10 @@
SimpleSwapPromiseMonitor(LayerTreeHost* layer_tree_host,
LayerTreeHostImpl* layer_tree_host_impl,
int* set_needs_commit_count,
- int* set_needs_redraw_count,
- int* forward_to_main_count)
+ int* set_needs_redraw_count)
: SwapPromiseMonitor(layer_tree_host, layer_tree_host_impl),
set_needs_commit_count_(set_needs_commit_count),
- set_needs_redraw_count_(set_needs_redraw_count),
- forward_to_main_count_(forward_to_main_count) {}
+ set_needs_redraw_count_(set_needs_redraw_count) {}
virtual ~SimpleSwapPromiseMonitor() {}
@@ -6402,32 +6382,24 @@
(*set_needs_redraw_count_)++;
}
- virtual void OnForwardScrollUpdateToMainThreadOnImpl() OVERRIDE {
- (*forward_to_main_count_)++;
- }
-
private:
int* set_needs_commit_count_;
int* set_needs_redraw_count_;
- int* forward_to_main_count_;
};
TEST_F(LayerTreeHostImplTest, SimpleSwapPromiseMonitor) {
int set_needs_commit_count = 0;
int set_needs_redraw_count = 0;
- int forward_to_main_count = 0;
{
scoped_ptr<SimpleSwapPromiseMonitor> swap_promise_monitor(
new SimpleSwapPromiseMonitor(NULL,
host_impl_.get(),
&set_needs_commit_count,
- &set_needs_redraw_count,
- &forward_to_main_count));
+ &set_needs_redraw_count));
host_impl_->SetNeedsRedraw();
EXPECT_EQ(0, set_needs_commit_count);
EXPECT_EQ(1, set_needs_redraw_count);
- EXPECT_EQ(0, forward_to_main_count);
}
// Now the monitor is destroyed, SetNeedsRedraw() is no longer being
@@ -6435,19 +6407,16 @@
host_impl_->SetNeedsRedraw();
EXPECT_EQ(0, set_needs_commit_count);
EXPECT_EQ(1, set_needs_redraw_count);
- EXPECT_EQ(0, forward_to_main_count);
{
scoped_ptr<SimpleSwapPromiseMonitor> swap_promise_monitor(
new SimpleSwapPromiseMonitor(NULL,
host_impl_.get(),
&set_needs_commit_count,
- &set_needs_redraw_count,
- &forward_to_main_count));
+ &set_needs_redraw_count));
host_impl_->SetNeedsRedrawRect(gfx::Rect(10, 10));
EXPECT_EQ(0, set_needs_commit_count);
EXPECT_EQ(2, set_needs_redraw_count);
- EXPECT_EQ(0, forward_to_main_count);
}
{
@@ -6455,49 +6424,12 @@
new SimpleSwapPromiseMonitor(NULL,
host_impl_.get(),
&set_needs_commit_count,
- &set_needs_redraw_count,
- &forward_to_main_count));
+ &set_needs_redraw_count));
// Empty damage rect won't signal the monitor.
host_impl_->SetNeedsRedrawRect(gfx::Rect());
EXPECT_EQ(0, set_needs_commit_count);
EXPECT_EQ(2, set_needs_redraw_count);
- EXPECT_EQ(0, forward_to_main_count);
}
-
- {
- set_needs_commit_count = 0;
- set_needs_redraw_count = 0;
- forward_to_main_count = 0;
- scoped_ptr<SimpleSwapPromiseMonitor> swap_promise_monitor(
- new SimpleSwapPromiseMonitor(NULL,
- host_impl_.get(),
- &set_needs_commit_count,
- &set_needs_redraw_count,
- &forward_to_main_count));
- LayerImpl* scroll_layer = SetupScrollAndContentsLayers(gfx::Size(100, 100));
-
- // Scrolling normally should not trigger any forwarding.
- EXPECT_EQ(InputHandler::ScrollStarted,
- host_impl_->ScrollBegin(gfx::Point(), InputHandler::Gesture));
- EXPECT_TRUE(host_impl_->ScrollBy(gfx::Point(), gfx::Vector2d(0, 10)));
- host_impl_->ScrollEnd();
-
- EXPECT_EQ(0, set_needs_commit_count);
- EXPECT_EQ(1, set_needs_redraw_count);
- EXPECT_EQ(0, forward_to_main_count);
-
- // Scrolling with a scroll handler should defer the swap to the main
- // thread.
- scroll_layer->SetHaveScrollEventHandlers(true);
- EXPECT_EQ(InputHandler::ScrollStarted,
- host_impl_->ScrollBegin(gfx::Point(), InputHandler::Gesture));
- EXPECT_TRUE(host_impl_->ScrollBy(gfx::Point(), gfx::Vector2d(0, 10)));
- host_impl_->ScrollEnd();
-
- EXPECT_EQ(0, set_needs_commit_count);
- EXPECT_EQ(2, set_needs_redraw_count);
- EXPECT_EQ(1, forward_to_main_count);
- }
}
class LayerTreeHostImplWithTopControlsTest : public LayerTreeHostImplTest {
« no previous file with comments | « trunk/src/cc/trees/layer_tree_host_impl.cc ('k') | trunk/src/cc/trees/layer_tree_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698