Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 436413004: Revert 287325 because it breaks smoothness benchmarks on windows: "ValueError: LatencyInfo has no b… (Closed)

Created:
6 years, 4 months ago by sadrul
Modified:
6 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 287325 because it breaks smoothness benchmarks on windows: "ValueError: LatencyInfo has no begin component" > Implement scroll handler latency tracking > > Since scroll handlers do not block composited scrolling, the existing > input latency metric will only report the response time for the > compositor when scrolling a page with a handler. This is not accurate > for pages that implement scroll-synchronized effects, because the > scroll handler needs to be invoked so that the page contents are > updated with the new scroll offset. > > This patch fixes the problem by forwarding latency information from the > impl to the main thread when we are scrolling a layer that has an active > scroll event handler. > > In the case the scroll handler is no-op, the latency information will be > terminated as a failed commit. > > Sample trace: > https://drive.google.com/file/d/0ByyxMXB38gLDRE40bkU5TVd0U00/edit?usp=sharing > > BUG=347366 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282117 > > Review URL: https://codereview.chromium.org/365463003 TBR=skyostil@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -220 lines) Patch
M trunk/src/cc/base/latency_info_swap_promise.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/cc/base/latency_info_swap_promise.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/cc/base/latency_info_swap_promise_monitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/base/latency_info_swap_promise_monitor.cc View 2 chunks +8 lines, -62 lines 0 comments Download
M trunk/src/cc/base/swap_promise.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/cc/base/swap_promise_monitor.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_host.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/cc/trees/layer_tree_host.cc View 2 chunks +11 lines, -20 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_common.h View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +5 lines, -73 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M trunk/src/cc/trees/thread_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/content/renderer/gpu/queue_message_swap_promise.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/renderer/gpu/queue_message_swap_promise.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/content/renderer/input/input_handler_proxy.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M trunk/src/ui/events/latency_info.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/ui/events/latency_info.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
6 years, 4 months ago (2014-08-05 04:57:28 UTC) #1
sadrul
6 years, 4 months ago (2014-08-05 04:57:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r287458.

Powered by Google App Engine
This is Rietveld 408576698