Move non-API code out of sync/api/attachments/

sync/api/attachments/attachment_store.h

Index: sync/api/attachments/attachment_store.h
diff --git a/sync/api/attachments/attachment_store.h b/sync/api/attachments/attachment_store.h
deleted file mode 100644
index b8834e0251f9da2e88e368f15151b49422c783b7..0000000000000000000000000000000000000000
--- a/sync/api/attachments/attachment_store.h
+++ /dev/null
@@ -1,89 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef SYNC_API_ATTACHMENTS_ATTACHMENT_STORE_H_
-#define SYNC_API_ATTACHMENTS_ATTACHMENT_STORE_H_
-
-#include "base/callback.h"
-#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_ptr.h"
-#include "sync/api/attachments/attachment.h"
-#include "sync/api/attachments/attachment_id.h"
-#include "sync/base/sync_export.h"
-
-namespace base {
-class RefCountedMemory;
-}  // namespace base
-
-namespace syncer {
-
-class Attachment;
-class AttachmentId;
-
-// A place to locally store and access Attachments.
-//
-// Destroying this object does not necessarily cancel outstanding async
-// operations. If you need cancel like semantics, use WeakPtr in the callbacks.
-class SYNC_EXPORT AttachmentStore {

[tim (not reviewing), 2014/08/05 16:47:55]

How likely is it this will move back to /api?

[maniscalco, 2014/08/05 18:05:57]

Quite likely.  I'll leave it there so we not moving it back and forth.

- public:
-  AttachmentStore();
-  virtual ~AttachmentStore();
-
-  // TODO(maniscalco): Consider udpating Read and Write methods to support
-  // resumable transfers (bug 353292).
-
-  enum Result {
-    SUCCESS,            // No error, all completed successfully.
-    UNSPECIFIED_ERROR,  // An unspecified error occurred for one or more items.
-  };
-
-  typedef base::Callback<void(const Result&,
-                              scoped_ptr<AttachmentMap>,
-                              scoped_ptr<AttachmentIdList>)> ReadCallback;
-  typedef base::Callback<void(const Result&)> WriteCallback;
-  typedef base::Callback<void(const Result&)> DropCallback;
-
-  // Asynchronously reads the attachments identified by |ids|.
-  //
-  // |callback| will be invoked when finished. AttachmentStore will attempt to
-  // read all attachments specified in ids. If any of the attachments do not
-  // exist or could not be read, |callback|'s Result will be UNSPECIFIED_ERROR.
-  // Callback's AttachmentMap will contain all attachments that were
-  // successfully read, AttachmentIdList will contain attachment ids of
-  // attachments that are unavailable in attachment store, these need to be
-  // downloaded from server.
-  //
-  // Reads on individual attachments are treated atomically; |callback| will not
-  // read only part of an attachment.
-  virtual void Read(const AttachmentIdList& ids,
-                    const ReadCallback& callback) = 0;
-
-  // Asynchronously writes |attachments| to the store.
-  //
-  // Will not overwrite stored attachments. Attempting to overwrite an
-  // attachment that already exists is not an error.
-  //
-  // |callback| will be invoked when finished. If any of the attachments could
-  // not be written |callback|'s Result will be UNSPECIFIED_ERROR. When this
-  // happens, some or none of the attachments may have been written
-  // successfully.
-  virtual void Write(const AttachmentList& attachments,
-                     const WriteCallback& callback) = 0;
-
-  // Asynchronously drops |attchments| from this store.
-  //
-  // This does not remove attachments from the server.
-  //
-  // |callback| will be invoked when finished. Attempting to drop an attachment
-  // that does not exist is not an error. If any of the existing attachment
-  // could not be dropped, |callback|'s Result will be UNSPECIFIED_ERROR. When
-  // this happens, some or none of the attachments may have been dropped
-  // successfully.
-  virtual void Drop(const AttachmentIdList& ids,
-                    const DropCallback& callback) = 0;
-};
-
-}  // namespace syncer
-
-#endif  // SYNC_API_ATTACHMENTS_ATTACHMENT_STORE_H_