Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 436353002: Add "Symbol" to the list of expected global constructors (Closed)

Created:
6 years, 4 months ago by adamk
Modified:
6 years, 4 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Add "Symbol" to the list of expected global constructors ECMAScript 6 Symbols were enabled by default in V8 in https://code.google.com/p/v8/source/detail?r=22831. This patch adds the proper baselines and marks the tests as failing. They'll start passing again after the next roll. BUG=400507 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179499

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 15 (0 generated)
adamk
6 years, 4 months ago (2014-08-04 20:56:07 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 4 months ago (2014-08-04 21:03:04 UTC) #2
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 4 months ago (2014-08-04 21:59:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/436353002/20001
6 years, 4 months ago (2014-08-04 22:00:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-04 23:25:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 23:29:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/14933)
6 years, 4 months ago (2014-08-04 23:29:36 UTC) #7
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 4 months ago (2014-08-05 07:07:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/436353002/20001
6 years, 4 months ago (2014-08-05 07:08:45 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-05 08:12:18 UTC) #10
Michael Achenbach
The CQ bit was unchecked by machenbach@chromium.org
6 years, 4 months ago (2014-08-05 08:18:04 UTC) #11
Michael Achenbach
win_rel has issues unrelated to this change. Will set notry.
6 years, 4 months ago (2014-08-05 08:18:30 UTC) #12
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 4 months ago (2014-08-05 08:18:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/436353002/20001
6 years, 4 months ago (2014-08-05 08:20:44 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 08:22:54 UTC) #15
Message was sent while issue was closed.
Change committed as 179499

Powered by Google App Engine
This is Rietveld 408576698