Created helper class for parsing Apple style XML dictionaries.

chrome/utility/media_galleries/iapps_xml_utils.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_UTILITY_MEDIA_GALLERIES_IAPPS_XML_UTILS_H_
 #define CHROME_UTILITY_MEDIA_GALLERIES_IAPPS_XML_UTILS_H_
 
+#include <set>
 #include <string>
 
 #include "base/files/file.h"
 
 class XmlReader;
 
 namespace iapps {
 
 // Like XmlReader::SkipToElement, but will advance to the next open tag if the
 // cursor is on a close tag.
 bool SkipToNextElement(XmlReader* reader);
 
 // Traverse |reader| looking for a node named |name| at the current depth
 // of |reader|.
 bool SeekToNodeAtCurrentDepth(XmlReader* reader, const std::string& name);
 
 // Search within a "dict" node for |key|. The cursor must be on the starting
 // "dict" node when entering this function.
 bool SeekInDict(XmlReader* reader, const std::string& key);
 
 // Get the value out of a string node.
 bool ReadString(XmlReader* reader, std::string* result);
 
 // Get the value out of an integer node.
 bool ReadInteger(XmlReader* reader, uint64* result);
 
 // Read in the contents of the given library xml |file| and return as a string.
 std::string ReadFileAsString(base::File file);
 
+class XmlDictReader {

[Lei Zhang, 2014/08/05 19:38:24]

This class can use some comments.

[Kevin Bailey, 2014/08/05 21:52:05]

Done.

+ public:
+  XmlDictReader(XmlReader* reader);

[Lei Zhang, 2014/08/05 19:38:24]

explicit

[Kevin Bailey, 2014/08/05 21:52:05]

Done.

+
+  bool Read();
+
+  virtual bool ShouldLoop();
+
+  bool HandleKey(const std::string& key) {

[Lei Zhang, 2014/08/05 19:38:24]

please put non-trivial impls in the .cc files.

[Kevin Bailey, 2014/08/05 21:52:05]

Done.

+    if (found_.find(key) != found_.end())

[Lei Zhang, 2014/08/05 19:38:24]

Just call Found()?

[Kevin Bailey, 2014/08/05 21:52:05]

Done.

+      return false;
+    if (HandleKeyImpl(key)) {
+      found_.insert(key);
+      return true;
+    }
+    return false;
+  }
+
+  virtual bool HandleKeyImpl(const std::string& key) = 0;
+
+  bool SkipToNext();
+
+  virtual bool FinishedOk();
+  virtual bool AllowRepeats();
+
+  bool Found(const std::string& key) {
+    return found_.find(key) != found_.end();

[Lei Zhang, 2014/08/05 19:38:24]

You can use ContainsKey() from base/stl_util.h.

[Kevin Bailey, 2014/08/05 21:52:05]

Done.

+  }
+
+  virtual ~XmlDictReader();

[Lei Zhang, 2014/08/05 19:38:24]

Put the dtor next to the ctor?

[Kevin Bailey, 2014/08/05 21:52:05]

Done.

+
+ protected:
+  XmlReader* reader_;
+
+ private:
+  std::set<std::string> found_;
+};

[Lei Zhang, 2014/08/05 19:38:24]

DISALLOW_COPY_AND_ASSIGN(XmlDictReader);

[Kevin Bailey, 2014/08/05 21:52:05]

Done.

+
 }  // namespace iapps
 
 #endif  // CHROME_UTILITY_MEDIA_GALLERIES_IAPPS_XML_UTILS_H_