Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Unified Diff: tools/generate-runtime-tests.py

Issue 436223003: Fix tools/generate-runtime-tests.py. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/runtime-gen/setproperty.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/generate-runtime-tests.py
diff --git a/tools/generate-runtime-tests.py b/tools/generate-runtime-tests.py
index 58175394a3d6ce2e1c6bc6ea0fbc9ae138c538bf..87e9d7ca3b0ab5bb9171f68e0d54d71a5a505f94 100755
--- a/tools/generate-runtime-tests.py
+++ b/tools/generate-runtime-tests.py
@@ -20,7 +20,7 @@ import time
FILENAME = "src/runtime.cc"
HEADERFILENAME = "src/runtime.h"
FUNCTION = re.compile("^RUNTIME_FUNCTION\(Runtime_(\w+)")
-ARGSLENGTH = re.compile(".*ASSERT\(.*args\.length\(\) == (\d+)\);")
+ARGSLENGTH = re.compile(".*DCHECK\(.*args\.length\(\) == (\d+)\);")
FUNCTIONEND = "}\n"
MACRO = re.compile(r"^#define ([^ ]+)\(([^)]*)\) *([^\\]*)\\?\n$")
FIRST_WORD = re.compile("^\s*(.*?)[\s({\[]")
@@ -48,9 +48,9 @@ EXPAND_MACROS = [
# remove or change runtime functions, but make sure we don't lose our ability
# to parse them!
EXPECTED_FUNCTION_COUNT = 425
-EXPECTED_FUZZABLE_COUNT = 338
-EXPECTED_CCTEST_COUNT = 9
-EXPECTED_UNKNOWN_COUNT = 4
+EXPECTED_FUZZABLE_COUNT = 328
+EXPECTED_CCTEST_COUNT = 7
+EXPECTED_UNKNOWN_COUNT = 16
EXPECTED_BUILTINS_COUNT = 816
@@ -58,7 +58,7 @@ EXPECTED_BUILTINS_COUNT = 816
BLACKLISTED = [
"Abort", # Kills the process.
"AbortJS", # Kills the process.
- "CompileForOnStackReplacement", # Riddled with ASSERTs.
+ "CompileForOnStackReplacement", # Riddled with DCHECK.
"IS_VAR", # Not implemented in the runtime.
"ListNatives", # Not available in Release mode.
"SetAllocationTimeout", # Too slow for fuzzing.
« no previous file with comments | « test/mjsunit/runtime-gen/setproperty.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698