content/shell/renderer/test_runner/mock_spell_check.cc - Issue 436133002: Migrate TestCommon to Chromium c++ style and remove un-used header.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/mock_spell_check.cc

Issue 436133002: Migrate TestCommon to Chromium c++ style and remove un-used header. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/renderer/test_runner/mock_grammar_check.cc ('k') | content/shell/renderer/test_runner/mock_web_media_stream_center.h » ('j') | content/shell/renderer/test_runner/test_common.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/mock_spell_check.cc

diff --git a/content/shell/renderer/test_runner/mock_spell_check.cc b/content/shell/renderer/test_runner/mock_spell_check.cc

index 6c861487a4339aad32e0c1a8ee2104dd52f2400b..4d4a3ce42c34f76b3b2b334aac33ec000ccff5d4 100644

--- a/content/shell/renderer/test_runner/mock_spell_check.cc

+++ b/content/shell/renderer/test_runner/mock_spell_check.cc

@@ -5,7 +5,7 @@

#include "content/shell/renderer/test_runner/mock_spell_check.h"

#include "base/logging.h"

-#include "content/shell/renderer/test_runner/TestCommon.h"

+#include "content/shell/renderer/test_runner/test_common.h"

#include "third_party/WebKit/public/platform/WebCString.h"

namespace content {

@@ -56,7 +56,7 @@ bool MockSpellCheck::SpellCheckWord(const blink::WebString& text,

// If the given string doesn't include any ASCII characters, we can treat

// the string as valid one.

base::string16::iterator first_char =

- std::find_if(string_text.begin(), string_text.end(), isASCIIAlpha);

+ std::find_if(string_text.begin(), string_text.end(), IsASCIIAlpha);

if (first_char == string_text.end())

return true;

int word_offset = std::distance(string_text.begin(), first_char);

@@ -78,7 +78,7 @@ bool MockSpellCheck::SpellCheckWord(const blink::WebString& text,

if (word == misspelled_words_.at(i) &&

(static_cast<int>(string_text.length()) ==

word_offset + word_length ||

- isNotASCIIAlpha(string_text[word_offset + word_length]))) {

+ IsNotASCIIAlpha(string_text[word_offset + word_length]))) {

*misspelled_offset = word_offset + skipped_length;

*misspelled_length = word_length;

break;

@@ -89,7 +89,7 @@ bool MockSpellCheck::SpellCheckWord(const blink::WebString& text,

break;

base::string16::iterator last_char = std::find_if(

- string_text.begin() + word_offset, string_text.end(), isNotASCIIAlpha);

+ string_text.begin() + word_offset, string_text.end(), IsNotASCIIAlpha);

if (last_char == string_text.end())

word_length = static_cast<int>(string_text.length()) - word_offset;

else