Fix app icon flicker in loading animation

chrome/browser/views/frame/browser_view.cc

Index: chrome/browser/views/frame/browser_view.cc
diff --git a/chrome/browser/views/frame/browser_view.cc b/chrome/browser/views/frame/browser_view.cc
index 8fbd80d3757d2bf21763f50c84e44ff8d3b8df71..dad49bb9bcf5319f983db072e363859fec328c1a 100644
--- a/chrome/browser/views/frame/browser_view.cc
+++ b/chrome/browser/views/frame/browser_view.cc
@@ -792,7 +792,7 @@ void BrowserView::SelectedTabExtensionShelfSizeChanged() {
 
 void BrowserView::UpdateTitleBar() {
   frame_->GetWindow()->UpdateWindowTitle();
-  if (ShouldShowWindowIcon())
+  if (ShouldShowWindowIcon() && !loading_animation_timer_.IsRunning())

[Ben Goodger (Google), 2009/11/24 20:54:31]

Does this mean no tab can update its favicon while any other tab is loading?

[xiyuan, 2009/11/24 21:05:05]

Tab's favicon update in tab strip should not be affected. ShouldShowWindowIcon()
is true only for chrome frame window with title bar (i.e. app and pop-up) and
UpdateWindowIcon belows updates the top-left icon for the frame window. The fix
is to skip the window icon set when frame window (GlassBrowserFrameView) uses it
for loading animation.

     frame_->GetWindow()->UpdateWindowIcon();
   browser_extender_->UpdateTitleBar();
 }