Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 436013002: Fix display options re-display regression. (Closed)

Created:
6 years, 4 months ago by Dan Beam
Modified:
6 years, 4 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix display options re-display regression. Without this fix, if display info has changed while the settings page is running the display info dialog will show stale data. BUG=399690 R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/resources/options/chromeos/display_options.js View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Beam
6 years, 4 months ago (2014-08-01 17:30:24 UTC) #1
stevenjb
lgtm
6 years, 4 months ago (2014-08-01 17:31:29 UTC) #2
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 4 months ago (2014-08-01 17:32:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/436013002/1
6 years, 4 months ago (2014-08-01 17:35:05 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 00:27:00 UTC) #5
Message was sent while issue was closed.
Change committed as 287130

Powered by Google App Engine
This is Rietveld 408576698