Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 436008: Fixes extension packing codepath that was hitting a race condition DCHECK des... (Closed)

Created:
11 years ago by Bons
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fixes extension packing codepath that was hitting a race condition DCHECK described in http://crbug.com/27944. BUG=28530 TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/extensions/extensions_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/pack_extension_job.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bons
11 years ago (2009-11-23 21:30:07 UTC) #1
Nico
I fear I'm not qualified to review this. If you need more reviewers than jam, ...
11 years ago (2009-11-23 21:39:14 UTC) #2
jam
11 years ago (2009-11-23 22:19:04 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698