Issue 436008: Fixes extension packing codepath that was hitting a race condition DCHECK des...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 436008: Fixes extension packing codepath that was hitting a race condition DCHECK des... (Closed)

Created:
11 years ago by Bons

Modified:
9 years, 5 months ago

Reviewers:
Erik does not do reviews, jam

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fixes extension packing codepath that was hitting a race condition DCHECK described in http://crbug.com/27944. BUG=28530 TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32898

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -0 lines)			Patch
M	chrome/browser/extensions/extensions_ui.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/pack_extension_job.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/pack_extension_job.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Nico

I fear I'm not qualified to review this. If you need more reviewers than jam, ...

11 years ago (2009-11-23 21:39:14 UTC) #2

lgtm