Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 435983003: GN: Add missing dep from //base:prefs_test_support on //testing/gtest. (Closed)

Created:
6 years, 4 months ago by jbroman
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

GN: Add missing dep from //base:prefs_test_support on //testing/gtest. gtest.h is included pref_store_observer_mock.cc and testing_pref_service.cc. Found using 'gn check'. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287540

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jbroman
seems straightforward; base_unittests still builds and passes
6 years, 4 months ago (2014-08-01 19:39:41 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-03 22:06:41 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 4 months ago (2014-08-05 14:33:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/435983003/1
6 years, 4 months ago (2014-08-05 14:35:35 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 14:44:07 UTC) #5
Message was sent while issue was closed.
Change committed as 287540

Powered by Google App Engine
This is Rietveld 408576698