Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 435963002: Remove old style NEON defines now that Skia has been updated (Closed)

Created:
6 years, 4 months ago by djsollen
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove old style NEON defines now that Skia has been updated BUG=skia:2785 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M skia/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M skia/skia_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
djsollen
This CL cannot land until the next successful roll of Skia into Chromium.
6 years, 4 months ago (2014-08-01 14:36:27 UTC) #1
djsollen
this is ready to go now, it just needs ben's stamp of approval.
6 years, 4 months ago (2014-08-04 12:43:16 UTC) #2
djsollen
6 years, 4 months ago (2014-08-04 13:31:42 UTC) #3
tomhudson
lgtm
6 years, 4 months ago (2014-08-04 13:32:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/djsollen@google.com/435963002/1
6 years, 4 months ago (2014-08-04 13:32:46 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 15:25:16 UTC) #6
Message was sent while issue was closed. 
Change committed as 287336

Powered by Google App Engine
This is Rietveld 408576698