Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 43593005: Move WebTransformKeyframe to platform/ (Closed)

Created:
7 years, 1 month ago by pilgrim_google
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, tommyw+watchlist_chromium.org, dglazkov+blink, abarth-chromium, darin (slow to review)
Visibility:
Public.

Description

Move WebTransformKeyframe to platform/ BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160725

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, add missing export macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -60 lines) Patch
M Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/platform/chromium/support/WebTransformKeyframe.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A + Source/platform/exported/WebTransformKeyframe.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebTransformKeyframe.h View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pilgrim_google
7 years, 1 month ago (2013-10-25 18:13:17 UTC) #1
abarth-chromium
LGTM https://codereview.chromium.org/43593005/diff/1/public/platform/WebTransformKeyframe.h File public/platform/WebTransformKeyframe.h (right): https://codereview.chromium.org/43593005/diff/1/public/platform/WebTransformKeyframe.h#newcode40 public/platform/WebTransformKeyframe.h:40: WebTransformKeyframe(double time, WTF::PassOwnPtr<WebTransformOperations> value); You're going to need ...
7 years, 1 month ago (2013-10-26 00:49:21 UTC) #2
pilgrim_google
rebase, add missing export macro
7 years, 1 month ago (2013-10-28 14:09:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/43593005/70001
7 years, 1 month ago (2013-10-28 14:10:29 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 15:20:49 UTC) #5
Message was sent while issue was closed.
Change committed as 160725

Powered by Google App Engine
This is Rietveld 408576698