Add layout switcher for virtual keyboard.

Add layout switcher for virtual keyboard.

BUG=311565
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231710

[kevers, 2013-10-25 14:11:05]

Hi Biao,

Can you please take a look at this CL.

[bshe, 2013-10-25 17:07:16]

looks like you didn't upload the new file
kb-options-menu.html ?

https://codereview.chromium.org/43593003/diff/30001/ui/keyboard/resources/ele...
File ui/keyboard/resources/elements/kb-keyset.html (right):

https://codereview.chromium.org/43593003/diff/30001/ui/keyboard/resources/ele...
ui/keyboard/resources/elements/kb-keyset.html:8: capsLocksTo capsLockable"
on-key-up="keyUp" on-key-longpress="keyLongpress">
nit: doesn't seem need to wrap?

[kevers, 2013-10-25 18:00:33]

Oops...added the missing file.

https://codereview.chromium.org/43593003/diff/30001/ui/keyboard/resources/ele...
File ui/keyboard/resources/elements/kb-keyset.html (right):

https://codereview.chromium.org/43593003/diff/30001/ui/keyboard/resources/ele...
ui/keyboard/resources/elements/kb-keyset.html:8: capsLocksTo capsLockable"
on-key-up="keyUp" on-key-longpress="keyLongpress">
On 2013/10/25 17:07:17, bshe wrote:
> nit: doesn't seem need to wrap?

Yes, this change removes the unnecessary wrap.

[bshe, 2013-10-28 15:20:20]

This looking good! Just have one concern

https://codereview.chromium.org/43593003/diff/130001/ui/keyboard/resources/el...
File ui/keyboard/resources/elements/kb-options-menu.html (right):

https://codereview.chromium.org/43593003/diff/130001/ui/keyboard/resources/el...
ui/keyboard/resources/elements/kb-options-menu.html:25: <span>{{label}}<span>
</span> ?

https://codereview.chromium.org/43593003/diff/130001/ui/keyboard/resources/el...
ui/keyboard/resources/elements/kb-options-menu.html:37: else
would it possible to dispatch an event instead of directly use keyboard.layout
here? It would be nice that inner element do not depend on parent element. We
probably want to use event to talk to parent element.

[kevers, 2013-10-28 15:40:16]

https://codereview.chromium.org/43593003/diff/130001/ui/keyboard/resources/el...
File ui/keyboard/resources/elements/kb-options-menu.html (right):

https://codereview.chromium.org/43593003/diff/130001/ui/keyboard/resources/el...
ui/keyboard/resources/elements/kb-options-menu.html:25: <span>{{label}}<span>
On 2013/10/28 15:20:20, bshe wrote:
> </span> ?

Done.

https://codereview.chromium.org/43593003/diff/130001/ui/keyboard/resources/el...
ui/keyboard/resources/elements/kb-options-menu.html:37: else
On 2013/10/28 15:20:20, bshe wrote:
> would it possible to dispatch an event instead of directly use keyboard.layout
> here? It would be nice that inner element do not depend on parent element. We
> probably want to use event to talk to parent element.

Done.

[bshe, 2013-10-28 15:41:12]

On 2013/10/28 15:40:16, kevers wrote:
>
https://codereview.chromium.org/43593003/diff/130001/ui/keyboard/resources/el...
> File ui/keyboard/resources/elements/kb-options-menu.html (right):
> 
>
https://codereview.chromium.org/43593003/diff/130001/ui/keyboard/resources/el...
> ui/keyboard/resources/elements/kb-options-menu.html:25: <span>{{label}}<span>
> On 2013/10/28 15:20:20, bshe wrote:
> > </span> ?
> 
> Done.
> 
>
https://codereview.chromium.org/43593003/diff/130001/ui/keyboard/resources/el...
> ui/keyboard/resources/elements/kb-options-menu.html:37: else
> On 2013/10/28 15:20:20, bshe wrote:
> > would it possible to dispatch an event instead of directly use
keyboard.layout
> > here? It would be nice that inner element do not depend on parent element.
We
> > probably want to use event to talk to parent element.
> 
> Done.

lgtm

[commit-bot: I haz the power, 2013-10-28 16:06:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/43593003/180001

[commit-bot: I haz the power, 2013-10-28 16:06:08]

Failed to apply patch for ui/keyboard/resources/elements/kb-keyboard.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ui/keyboard/resources/elements/kb-keyboard.html
  Hunk #1 FAILED at 7.
  Hunk #4 succeeded at 576 (offset 2 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
ui/keyboard/resources/elements/kb-keyboard.html.rej

Patch:       ui/keyboard/resources/elements/kb-keyboard.html
Index: ui/keyboard/resources/elements/kb-keyboard.html
diff --git a/ui/keyboard/resources/elements/kb-keyboard.html
b/ui/keyboard/resources/elements/kb-keyboard.html
index
23d82272997244b2b83049684e1334045c7642ab..b1879ed489cd29970b41d3027468a781f3fa8d75
100644
--- a/ui/keyboard/resources/elements/kb-keyboard.html
+++ b/ui/keyboard/resources/elements/kb-keyboard.html
@@ -7,7 +7,8 @@
 <polymer-element name="kb-keyboard" on-key-over="keyOver" on-key-up="keyUp"
     on-key-down="keyDown" on-key-longpress="keyLongpress" on-pointerup="up"
     on-pointerdown="down" on-enable-sel="enableSel"
-    on-enable-dbl="enableDbl"  on-key-out="keyOut"
+    on-enable-dbl="enableDbl"  on-key-out="keyOut"
on-show-options="showOptions"
+    on-set-layout="setLayout"
     attributes="keyset layout rows inputType inputTypeToLayoutMap">
   <template>
     <style>
@@ -24,6 +25,7 @@
       -- keyboard layouts.
       -->
     <content select="#{{layout}}-{{keyset}}"></content>
+    <kb-keyboard-overlay id="overlay" hidden></kb-keyboard-overlay>
     <kb-key-codes id="keyCodeMetadata"></kb-key-codes>
   </template>
   <script>
@@ -215,7 +217,7 @@
       inputTypeToLayoutMap: {
         number: "numeric",
         text: "qwerty",
-        password: "system-qwerty"
+        password: "qwerty"
       },
 
       /**
@@ -573,6 +575,41 @@
       },
 
       /**
+       * Show menu for selecting a keyboard layout.
+       * @param {!Event} event The triggering event.
+       * @param {{left: number, top: number, width: number}} details Location
of
+       *     the button that triggered the popup.
+       */
+      showOptions: function(event, details) {
+        var overlay = this.$.overlay;
+        if (!overlay) {
+          console.error('Missing overlay.');
+          return;
+        }
+        var menu = overlay.$.options;
+        if (!menu) {
+           console.error('Missing options menu.');
+        }
+
+        menu.hidden = false;
+        overlay.hidden = false;
+        var left = details.left + details.width - menu.clientWidth;
+        var top = details.top - menu.clientHeight;
+        menu.style.left = left + 'px';
+        menu.style.top = top + 'px';
+      },
+
+      /**
+       * Handler for the 'set-layout' event.
+       * @param {!Event} event The triggering event.
+       * @param {{layout: string}} details Details of the event, which contains
+       *     the name of the layout to activate.
+       */
+      setLayout: function(event, details) {
+        this.layout = details.layout;
+      },
+
+      /**
        * Handles a change in the keyboard layout. Auto-selects the default
        * keyset for the new layout.
        */

[commit-bot: I haz the power, 2013-10-28 19:04:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/43593003/300001

[commit-bot: I haz the power, 2013-10-28 22:40:02]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-10-29 15:14:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/43593003/550001

[commit-bot: I haz the power, 2013-10-29 19:32:56]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-10-29 19:54:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/43593003/550001

[commit-bot: I haz the power, 2013-10-30 01:59:14]

Change committed as 231710