Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: src/compiler/representation-change.h

Issue 435923002: TF: Rename ConvertXToY machine operators to ChangeXToY. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/opcodes.h ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/representation-change.h
diff --git a/src/compiler/representation-change.h b/src/compiler/representation-change.h
index 824e22ba29f1a42070b62084f9b8ac9b9f8570e9..026bb9e6deb36cffa642245b28594bfe7bd5934c 100644
--- a/src/compiler/representation-change.h
+++ b/src/compiler/representation-change.h
@@ -150,9 +150,9 @@ class RepresentationChanger {
Operator* op;
if (output_type & rWord32) {
if (output_type & tUint32) {
- op = machine()->ConvertUint32ToFloat64();
+ op = machine()->ChangeUint32ToFloat64();
} else if (output_type & tInt32) {
- op = machine()->ConvertInt32ToFloat64();
+ op = machine()->ChangeInt32ToFloat64();
} else {
return TypeError(node, output_type, rFloat64);
}
@@ -188,12 +188,10 @@ class RepresentationChanger {
// Select the correct X -> Word32 operator.
Operator* op = NULL;
if (output_type & rFloat64) {
- // TODO(turbofan): could have cheaper float64 conversions that don't do
- // the full JavaScript truncation here.
if (output_type & tUint32) {
- op = machine()->ConvertFloat64ToUint32();
+ op = machine()->ChangeFloat64ToUint32();
} else if (output_type & tInt32) {
- op = machine()->ConvertFloat64ToInt32();
+ op = machine()->ChangeFloat64ToInt32();
} else {
return TypeError(node, output_type, rWord32);
}
« no previous file with comments | « src/compiler/opcodes.h ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698