Fix some infobar problems.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
@@ skipping 1368 matching lines @@
 }
 
 // (Private)
 - (void)finalizeState {
   // We promise that our delegate that the variables will be finalized before
   // the call to |-bookmarkBar:didChangeFromState:toState:|.
   BookmarkBar::State oldState = lastState_;
   lastState_ = currentState_;
   isAnimationRunning_ = NO;
 
+  // Update ourselves visually.
+  [self updateVisibility];
+
   // Notify our delegate.
   [delegate_ bookmarkBar:self
       didChangeFromState:oldState
                  toState:currentState_];

[Malcolm, 2014/08/08 10:51:51]

We should guarantee everything is done before notify the delegate.

-
-  // Update ourselves visually.
-  [self updateVisibility];
 }
 
 // (Private)
 - (void)stopCurrentAnimation {
   [[self animatableView] stopAnimation];
 }
 
 // Delegate method for |AnimatableView| (a superclass of
 // |BookmarkBarToolbarView|).
 - (void)animationDidEnd:(NSAnimation*)animation {
@@ skipping 1391 matching lines @@
 - (id<BookmarkButtonControllerProtocol>)controllerForNode:
     (const BookmarkNode*)node {
   // See if it's in the bar, then if it is in the hierarchy of visible
   // folder menus.
   if (bookmarkModel_->bookmark_bar_node() == node)
     return self;
   return [folderController_ controllerForNode:node];
 }
 
 @end