Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 435813002: [NaCl SDK] Fix typo in build_sdk.py. (Closed)

Created:
6 years, 4 months ago by Sam Clegg
Modified:
6 years, 4 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Fix typo in build_sdk.py. The name of the gyp variable for disabling arm components was mis-typed. R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sam Clegg
6 years, 4 months ago (2014-07-31 23:11:00 UTC) #1
binji
lgtm
6 years, 4 months ago (2014-08-01 01:00:41 UTC) #2
Sam Clegg
6 years, 4 months ago (2014-08-05 11:44:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 287516 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698