Implement minlength for <input> and <textarea>.

Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
@@ skipping 89 matching lines @@
 // get rather sluggish when a text field has a larger number of characters than
 // this, even when just clicking in the text field.
 const int HTMLInputElement::maximumLength = 524288;
 const int defaultSize = 20;
 const int maxSavedResults = 256;
 
 HTMLInputElement::HTMLInputElement(Document& document, HTMLFormElement* form, bool createdByParser)
     : HTMLTextFormControlElement(inputTag, document, form)
     , m_size(defaultSize)
     , m_maxLength(maximumLength)
+    , m_minLength(0)
     , m_maxResults(-1)
     , m_isChecked(false)
     , m_reflectsCheckedAttribute(true)
     , m_isIndeterminate(false)
     , m_isActivatedSubmit(false)
     , m_autocomplete(Uninitialized)
     , m_hasNonEmptyList(false)
     , m_stateRestored(false)
     , m_parsingInProgress(createdByParser)
     , m_valueAttributeWasUpdatedAfterParsing(false)
@@ skipping 90 matching lines @@
         && !tooLong(value, IgnoreDirtyFlag)
         && !m_inputType->patternMismatch(value)
         && !m_inputType->valueMissing(value);
 }
 
 bool HTMLInputElement::tooLong() const
 {
     return willValidate() && tooLong(value(), CheckDirtyFlag);
 }
 
+bool HTMLInputElement::tooShort() const
+{
+    bool ret = willValidate() && tooShort(value(), CheckDirtyFlag);
+    return ret;
+}
+
 bool HTMLInputElement::typeMismatch() const
 {
     return willValidate() && m_inputType->typeMismatch();
 }
 
 bool HTMLInputElement::valueMissing() const
 {
     return willValidate() && m_inputType->valueMissing(value());
 }
 
 bool HTMLInputElement::hasBadInput() const
 {
     return willValidate() && m_inputType->hasBadInput();
 }
 
 bool HTMLInputElement::patternMismatch() const
 {
     return willValidate() && m_inputType->patternMismatch(value());
 }
 
 bool HTMLInputElement::tooLong(const String& value, NeedsToCheckDirtyFlag check) const
 {
-    // We use isTextType() instead of supportsMaxLength() because of the
-    // 'virtual' overhead.
     if (!isTextType())
         return false;
     int max = maxLength();
     if (max < 0)
         return false;
     if (check == CheckDirtyFlag) {
         // Return false for the default value or a value set by a script even if
         // it is longer than maxLength.
         if (!hasDirtyValue() || !lastChangeWasUserEdit())
             return false;
     }
     return value.length() > static_cast<unsigned>(max);
 }
 
+bool HTMLInputElement::tooShort(const String& value, NeedsToCheckDirtyFlag check) const
+{
+    if (!isTextType())

[keishi, 2014/08/01 03:14:54]

We don't have WMLInputElement anymore so I think we can move this to
BaseTextInputType
https://bugs.webkit.org/show_bug.cgi?id=42814

[Bartek Nowierski, 2014/10/03 12:52:00]

The code has been moved to forms/BaseTextInputType.cpp and looks this has
disappeared there.

+        return false;
+    int min = minLength();
+    if (min <= 0)
+        return false;
+    if (check == CheckDirtyFlag) {
+        // Return false for the default value or a value set by a script even if
+        // it is shorter than minLength.
+        if (!hasDirtyValue() || !lastChangeWasUserEdit())
+            return false;
+    }
+    // An empty string is excluded from minlength check.
+    unsigned len = value.length();
+    return len > 0 && len < static_cast<unsigned>(min);
+}
+
 bool HTMLInputElement::rangeUnderflow() const
 {
     return willValidate() && m_inputType->rangeUnderflow(value());
 }
 
 bool HTMLInputElement::rangeOverflow() const
 {
     return willValidate() && m_inputType->rangeOverflow(value());
 }
 
@@ skipping 390 matching lines @@
         m_inputTypeView->valueAttributeChanged();
     } else if (name == checkedAttr) {
         // Another radio button in the same group might be checked by state
         // restore. We shouldn't call setChecked() even if this has the checked
         // attribute. So, delay the setChecked() call until
         // finishParsingChildren() is called if parsing is in progress.
         if (!m_parsingInProgress && m_reflectsCheckedAttribute) {
             setChecked(!value.isNull());
             m_reflectsCheckedAttribute = true;
         }
-    } else if (name == maxlengthAttr)
+    } else if (name == maxlengthAttr) {
         parseMaxLengthAttribute(value);
-    else if (name == sizeAttr) {
+    } else if (name == minlengthAttr) {
+        parseMinLengthAttribute(value);
+    } else if (name == sizeAttr) {
         int oldSize = m_size;
         int valueAsInteger = value.toInt();
         m_size = valueAsInteger > 0 ? valueAsInteger : defaultSize;
         if (m_size != oldSize && renderer())
             renderer()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidation();
     } else if (name == altAttr)
         m_inputTypeView->altAttributeChanged();
     else if (name == srcAttr)
         m_inputTypeView->srcAttributeChanged();
     else if (name == usemapAttr || name == accesskeyAttr) {
@@ skipping 600 matching lines @@
 const AtomicString& HTMLInputElement::alt() const
 {
     return fastGetAttribute(altAttr);
 }
 
 int HTMLInputElement::maxLength() const
 {
     return m_maxLength;
 }
 
+int HTMLInputElement::minLength() const
+{
+    return m_minLength;
+}
+
 void HTMLInputElement::setMaxLength(int maxLength, ExceptionState& exceptionState)
 {
     if (maxLength < 0)
         exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(maxLength) + ") is negative.");
+    else if (maxLength < m_minLength)
+        exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(maxLength) + ") is less than minlength" + String::number(m_minLength) + ".");
     else
         setIntegralAttribute(maxlengthAttr, maxLength);
 }
 
+void HTMLInputElement::setMinLength(int minLength, ExceptionState& exceptionState)
+{
+    if (minLength < 0)
+        exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(minLength) + ") is negative.");
+    else if (minLength > m_maxLength)
+        exceptionState.throwDOMException(IndexSizeError, "The value provided (" + String::number(minLength) + ") is more than maxlength" + String::number(m_maxLength) + ".");
+    else
+        setIntegralAttribute(minlengthAttr, minLength);
+}
+
 bool HTMLInputElement::multiple() const
 {
     return fastHasAttribute(multipleAttr);
 }
 
 void HTMLInputElement::setSize(unsigned size)
 {
     setUnsignedIntegralAttribute(sizeAttr, size);
 }
 
@@ skipping 358 matching lines @@
     return m_inputTypeView->updatePlaceholderText();
 }
 
 void HTMLInputElement::parseMaxLengthAttribute(const AtomicString& value)
 {
     int maxLength;
     if (!parseHTMLInteger(value, maxLength))
         maxLength = maximumLength;
     if (maxLength < 0 || maxLength > maximumLength)
         maxLength = maximumLength;
+    if (m_minLength > maxLength)

[keishi, 2014/08/01 03:14:54]

We should just apply the rules for "parsing non-negative integers" here and not
care about minLength. 

[Bartek Nowierski, 2014/10/03 12:52:00]

I assume you want me to remove this part. Done.

+        m_minLength = maxLength;
     int oldMaxLength = m_maxLength;
     m_maxLength = maxLength;
     if (oldMaxLength != maxLength)
         updateValueIfNeeded();
     setNeedsStyleRecalc(SubtreeStyleChange);
     setNeedsValidityCheck();
 }
 
+void HTMLInputElement::parseMinLengthAttribute(const AtomicString& value)
+{
+    int minLength;
+    if (!parseHTMLInteger(value, minLength))
+        minLength = 0;
+    if (minLength < 0)
+        minLength = 0;
+    if (minLength > m_maxLength)

[keishi, 2014/08/01 03:14:54]

We should just parse the minLength value here and not care about maxLength.

[Bartek Nowierski, 2014/10/03 12:52:00]

Done.

+        minLength = m_maxLength;
+    m_minLength = minLength;
+    setNeedsStyleRecalc(SubtreeStyleChange);
+    setNeedsValidityCheck();
+}
+
 void HTMLInputElement::updateValueIfNeeded()
 {
     String newValue = sanitizeValue(m_valueIfDirty);
     ASSERT(!m_valueIfDirty.isNull() || newValue.isNull());
     if (newValue != m_valueIfDirty)
         setValue(newValue);
 }
 
 String HTMLInputElement::defaultToolTip() const
 {
@@ skipping 185 matching lines @@
 {
     return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue);
 }
 
 void HTMLInputElement::didNotifySubtreeInsertionsToDocument()
 {
     listAttributeTargetChanged();
 }
 
 } // namespace