Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 435753002: add a libjpeg test (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add a libjpeg test This tests for a bug in libjpeg where INT32 is typedefed to long and memory is written to outside of the array. BUG=skia:2791 Committed: https://skia.googlesource.com/skia/+/a0cc8334dab67746c6a74807db92ce2607ed52ff

Patch Set 1 #

Patch Set 2 : remove failing assert, use AutoMalloc #

Total comments: 2

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M tests/ImageDecodingTest.cpp View 1 2 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hal.canary
6 years, 4 months ago (2014-07-31 21:20:36 UTC) #1
hal.canary
used malloc, removed failing assert
6 years, 4 months ago (2014-08-01 14:16:19 UTC) #2
djsollen
lgtm with a few nits https://codereview.chromium.org/435753002/diff/20001/tests/ImageDecodingTest.cpp File tests/ImageDecodingTest.cpp (right): https://codereview.chromium.org/435753002/diff/20001/tests/ImageDecodingTest.cpp#newcode761 tests/ImageDecodingTest.cpp:761: // If the pixels ...
6 years, 4 months ago (2014-08-01 14:21:26 UTC) #3
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-01 14:59:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/435753002/40001
6 years, 4 months ago (2014-08-01 14:59:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-08-01 15:12:48 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 15:20:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1078)
6 years, 4 months ago (2014-08-01 15:20:09 UTC) #8
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-01 17:17:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/435753002/40001
6 years, 4 months ago (2014-08-01 17:18:50 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 17:31:52 UTC) #11
Message was sent while issue was closed.
Change committed as a0cc8334dab67746c6a74807db92ce2607ed52ff

Powered by Google App Engine
This is Rietveld 408576698