Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 435703002: Move tests from Chrome's unit_tests to extensions_unittests (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move tests from Chrome's unit_tests to extensions_unittests Part of extensions module componentization. * Add a NotificationService for EventRouterTest * Move the test data for ValueStoreFrontendTest * The rest can move unchanged BUG=397164 TEST=unit_tests, extensions_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287159

Patch Set 1 #

Patch Set 2 : (browser-unit-tests) leveldb_value_store #

Patch Set 3 : (browser-unit-tests) size_t to int #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -22 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 3 chunks +1 line, -22 lines 0 comments Download
D chrome/test/data/value_store_db/000005.log View Binary file 0 comments Download
D chrome/test/data/value_store_db/CURRENT View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/value_store_db/LOCK View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/value_store_db/MANIFEST-000004 View Binary file 0 comments Download
M extensions/browser/event_router_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M extensions/browser/value_store/value_store_frontend_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 chunks +28 lines, -0 lines 0 comments Download
A + extensions/test/data/value_store_db/000005.log View Binary file 0 comments Download
A + extensions/test/data/value_store_db/CURRENT View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/value_store_db/LOCK View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/test/data/value_store_db/MANIFEST-000004 View Binary file 0 comments Download

Messages

Total messages: 9 (0 generated)
James Cook
yoz, PTAL
6 years, 4 months ago (2014-07-31 18:00:13 UTC) #1
Yoyo Zhou
LGTM
6 years, 4 months ago (2014-08-01 15:52:25 UTC) #2
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-01 15:57:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/435703002/20001
6 years, 4 months ago (2014-08-01 15:58:49 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-01 20:08:10 UTC) #5
James Cook
The CQ bit was unchecked by jamescook@chromium.org
6 years, 4 months ago (2014-08-01 20:28:48 UTC) #6
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-01 20:32:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/435703002/40001
6 years, 4 months ago (2014-08-01 20:35:08 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 05:55:20 UTC) #9
Message was sent while issue was closed. 
Change committed as 287159

Powered by Google App Engine
This is Rietveld 408576698