Issue 435673002: DM: only depend on GpuTest when it's a GPU build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 435673002: DM: only depend on GpuTest when it's a GPU build. (Closed)

Created:
6 years, 4 months ago by mtklein_C

Modified:
6 years, 4 months ago

Reviewers:
bsalomon, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

DM: only depend on GpuTest when it's a GPU build. This seems to fix DM dynamic linking errors on IntelRHB. Not clear why this device is the only one with this problem. It does set skia_gpu=0, but I can't reproduce the same failure on my desktop (skia_gpu=0, skia_shared_lib=1, skia_arch_width=32). BUG=skia: Committed: https://skia.googlesource.com/skia/+/e681c2a5061022511fbdf93319fb4b6043a5fb58

Patch Set 1 #

Patch Set 2 : fix via gyp instead #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	gyp/dm.gypi	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/435673002/20001

6 years, 4 months ago (2014-07-31 18:15:06 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-07-31 18:27:04 UTC) #5

Message was sent while issue was closed.

Change committed as e681c2a5061022511fbdf93319fb4b6043a5fb58

Expand Messages | Collapse Messages