Issue 43563005: Remove RealtimeAnalyser's virtual destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43563005: Remove RealtimeAnalyser's virtual destructor (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
Ken Russell (switch to Gerrit), abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove RealtimeAnalyser's virtual destructor Remove RealtimeAnalyser's destructor as it was empty and marked as virtual. This avoids creating an unnecessary vtable as this class is never subclassed nor does it have any virtual function. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160636

Patch Set 1 #

Patch Set 2 : Mark classes as FINAL #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
		Source/modules/webaudio/RealtimeAnalyser.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
		Source/modules/webaudio/RealtimeAnalyser.cpp	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

Please see my comment on http://crbug.com/311561 . I'd like that answered before reviewing this CL.

7 years, 1 month ago (2013-10-25 20:59:21 UTC) #2

Inactive

On 2013/10/25 20:59:21, Ken Russell wrote: > Please see my comment on http://crbug.com/311561 . I'd ...

7 years, 1 month ago (2013-10-25 21:58:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/43563005/70001

7 years, 1 month ago (2013-10-25 22:20:28 UTC) #5

Message was sent while issue was closed.

Change committed as 160636

Expand Messages | Collapse Messages