Issue 43563002: Generalize AllocationSite field access in HObjectAccess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43563002: Generalize AllocationSite field access in HObjectAccess. (Closed)

Created:
7 years, 2 months ago by mvstanton

Modified:
7 years, 1 month ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Generalize AllocationSite field access in HObjectAccess. There are simply becoming too many individual field accessors, and more are coming. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17408

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment response #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -21 lines)			Patch
	M	src/code-stubs-hydrogen.cc	View		5 chunks	+12 lines, -7 lines	0 comments	Download
	M	src/hydrogen-instructions.h	View	1	1 chunk	+3 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM https://codereview.chromium.org/43563002/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/43563002/diff/1/src/hydrogen-instructions.h#newcode5790 src/hydrogen-instructions.h:5790: ASSERT(offset < AllocationSite::kSize); && offset >= HeapObject::kHeaderSize

7 years, 1 month ago (2013-10-28 09:13:37 UTC) #2

mvstanton

thanks much! https://codereview.chromium.org/43563002/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/43563002/diff/1/src/hydrogen-instructions.h#newcode5790 src/hydrogen-instructions.h:5790: ASSERT(offset < AllocationSite::kSize); On 2013/10/28 09:13:38, Hannes ...

7 years, 1 month ago (2013-10-28 09:36:11 UTC) #3

mvstanton

7 years, 1 month ago (2013-10-28 09:36:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r17408 (presubmit successful).

Expand Messages | Collapse Messages