Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 435603011: jankometer: Remove. (Closed)

Created:
6 years, 4 months ago by sadrul
Modified:
6 years, 4 months ago
CC:
chromium-reviews, jar (doing other things), brettw, ramant (doing other things), Peter Kasting
Project:
chromium
Visibility:
Public.

Description

jankometer: Remove. The histograms don't seem to be used anymore (do not show up in UMA). The hang-detector and about:profiler produce relevant useful data for detecting jank. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -458 lines) Patch
M chrome/browser/browser_shutdown.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/jankometer.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/jankometer_stub.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/jankometer_win.cc View 1 chunk +0 lines, -394 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jar (doing other things)
FWIW: I think we get more results these days from the hang-detector, and we also ...
6 years, 4 months ago (2014-08-03 01:17:07 UTC) #1
sadrul
+jam@ for owner
6 years, 4 months ago (2014-08-05 04:19:57 UTC) #2
jar (doing other things)
LGTM
6 years, 4 months ago (2014-08-05 23:39:07 UTC) #3
jam
i'm overloaded with CY, please pick another owner from chrome
6 years, 4 months ago (2014-08-07 05:44:29 UTC) #4
sadrul
jam@ --> thestig@
6 years, 4 months ago (2014-08-07 05:54:19 UTC) #5
Lei Zhang (Do not use)
lgtm +pkasting FYI since a cmd line switch is being removed.
6 years, 4 months ago (2014-08-07 06:22:01 UTC) #6
sadrul
On 2014/08/07 06:22:01, Lei Zhang (Do not use) wrote: > lgtm Mind giving the approval ...
6 years, 4 months ago (2014-08-07 14:48:14 UTC) #7
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-07 16:22:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sadrul@chromium.org/435603011/1
6 years, 4 months ago (2014-08-07 16:24:06 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 19:43:54 UTC) #10
Message was sent while issue was closed.
Change committed as 288117

Powered by Google App Engine
This is Rietveld 408576698