Fix crash when trying to connect to an IPv6 IP via a SOCKS4 proxy.

net/socket/socks_client_socket_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/socks_client_socket.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "net/base/address_list.h"
 #include "net/base/net_log.h"
 #include "net/base/net_log_unittest.h"
 #include "net/base/test_completion_callback.h"
 #include "net/base/winsock_init.h"
+#include "net/dns/host_resolver.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/socket/client_socket_factory.h"
 #include "net/socket/socket_test_util.h"
 #include "net/socket/tcp_client_socket.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/platform_test.h"
 
 //-----------------------------------------------------------------------------
 
 namespace net {
@@ skipping 384 matching lines @@
 
   // Disconnect the SOCKS socket -- this should cancel the outstanding resolve.
   user_sock_->Disconnect();
 
   EXPECT_FALSE(hanging_resolver->HasOutstandingRequest());
 
   EXPECT_FALSE(user_sock_->IsConnected());
   EXPECT_FALSE(user_sock_->IsConnectedAndIdle());
 }
 
+// Tries to connect to an IPv6 IP.  Should fail, as SOCKS4 does not support
+// IPv6.
+TEST_F(SOCKSClientSocketTest, NoIPv6) {
+  const char kHostName[] = "::1";
+
+  // Use a real HostResolver for this test, as the MockHostResolver has its own

[Deprecated (see juliatuttle), 2014/08/04 20:32:20]

Perhaps test the behavior of both of them, to ensure they stay in sync?

[mmenke, 2014/08/05 22:50:38]

Done.

+  // code to handle raw IP addresses, and this serves to test that code as
+  // well.
+  scoped_ptr<HostResolver> host_resolver(
+      HostResolver::CreateSystemResolver(HostResolver::Options(), NULL));
+
+  user_sock_ = BuildMockSocket(NULL, 0,
+                               NULL, 0,
+                               host_resolver.get(),
+                               kHostName, 80,
+                               NULL);
+
+  EXPECT_EQ(ERR_NAME_NOT_RESOLVED,
+            callback_.GetResult(user_sock_->Connect(callback_.callback())));
+}
+
 }  // namespace net