Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 435603006: Cleanup: Switch some unit_tests gyp conditions from excluding to including. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, Scott Hess - ex-Googler
Project:
chromium
Visibility:
Public.

Description

Cleanup: Switch some unit_tests gyp conditions from excluding to including. Also do not bother building PPAPI test support code when plugins are disabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287292

Patch Set 1 #

Patch Set 2 : flip a conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -110 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 14 chunks +93 lines, -110 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
brettw: Please review. The only effective change is the ppapi test files. shess: This will ...
6 years, 4 months ago (2014-08-01 01:15:47 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-08-03 23:40:11 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-04 04:12:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/435603006/40001
6 years, 4 months ago (2014-08-04 04:13:17 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 04:41:14 UTC) #5
Message was sent while issue was closed.
Change committed as 287292

Powered by Google App Engine
This is Rietveld 408576698