ui/gfx/render_text.h - Issue 435583003: RenderTextHarfBuzz: Check CreateSkiaTypeface return value against NULL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/render_text.h

Issue 435583003: RenderTextHarfBuzz: Check CreateSkiaTypeface return value against NULL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/render_text.h

diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h

index bc848c30dcc79100c810ab979b1498c04684f30d..f5cb746527ae697fb684406e1baed7376d870271 100644

--- a/ui/gfx/render_text.h

+++ b/ui/gfx/render_text.h

@@ -175,6 +175,7 @@ struct Line {

};

// Creates an SkTypeface from a font |family| name and a |gfx::Font::FontStyle|.

+// May return NULL.

skia::RefPtr<SkTypeface> CreateSkiaTypeface(const std::string& family,

int style);

« no previous file with comments | « no previous file | ui/gfx/render_text_harfbuzz.h » ('j') | no next file with comments »