Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: ui/gfx/render_text_harfbuzz.h

Issue 435583003: RenderTextHarfBuzz: Check CreateSkiaTypeface return value against NULL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add tests Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text_harfbuzz.h
diff --git a/ui/gfx/render_text_harfbuzz.h b/ui/gfx/render_text_harfbuzz.h
index 7c304c06c9867fc07e6679fd32879251f7788bf0..b028a37a3ab0bf0147d1e4b85f382b5327f5a58a 100644
--- a/ui/gfx/render_text_harfbuzz.h
+++ b/ui/gfx/render_text_harfbuzz.h
@@ -107,6 +107,7 @@ class GFX_EXPORT RenderTextHarfBuzz : public RenderText {
FRIEND_TEST_ALL_PREFIXES(RenderTextTest, HarfBuzz_BreakRunsByUnicodeBlocks);
FRIEND_TEST_ALL_PREFIXES(RenderTextTest, HarfBuzz_SubglyphGraphemeCases);
FRIEND_TEST_ALL_PREFIXES(RenderTextTest, HarfBuzz_SubglyphGraphemePartition);
+ FRIEND_TEST_ALL_PREFIXES(RenderTextTest, HarfBuzz_NonExistentFont);
// Return the run index that contains the argument; or the length of the
// |runs_| vector if argument exceeds the text length or width.
@@ -126,7 +127,7 @@ class GFX_EXPORT RenderTextHarfBuzz : public RenderText {
// Shape the glyphs needed for the text |run|.
void ShapeRun(internal::TextRunHarfBuzz* run);
- void ShapeRunWithFont(internal::TextRunHarfBuzz* run,
+ bool ShapeRunWithFont(internal::TextRunHarfBuzz* run,
const std::string& font);
// Text runs in logical order.

Powered by Google App Engine
This is Rietveld 408576698