DeletableItemList: Make 'X' button delete only the one list item that contains it.

chrome/browser/resources/options/deletable_item_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var List = cr.ui.List;
   /** @const */ var ListItem = cr.ui.ListItem;
 
   /**
    * Creates a deletable list item, which has a button that will trigger a call
@@ skipping 118 matching lines @@
      * Callback for onclick events.
      * @param {Event} e The click event object.
      * @private
      */
     handleClick_: function(e) {
       if (this.disabled)
         return;
 
       var target = e.target;
       if (target.classList.contains('row-delete-button')) {
+        // A close button does not give any visual indication that its behavior
+        // would be affected by the current selection, so it should not be.

[Evan Stade, 2014/07/31 19:36:07]

I just don't think that code comments are the best place to justify or explain
behavioral choices (except in the case where the code is super complicated for
an unapparent reason).

[engedy, 2014/08/01 08:06:25]

Done, I have removed the comment.

         var listItem = this.getListItemAncestor(target);
-        var selected = this.selectionModel.selectedIndexes;
-
-        // Check if the list item that contains the close button being clicked
-        // is not in the list of selected items. Only delete this item in that
-        // case.
         var idx = this.getIndexOfListItem(listItem);
-        if (selected.indexOf(idx) == -1) {
-          this.deleteItemAtIndex(idx);
-        } else {
-          this.deleteSelectedItems_();
-        }
+        this.deleteItemAtIndex(idx);
       }
     },
 
     /**
      * Callback for keydown events.
      * @param {Event} e The keydown event object.
      * @private
      */
     handleKeyDown_: function(e) {
       // Map delete (and backspace on Mac) to item deletion (unless focus is
@@ skipping 28 matching lines @@
      */
     deleteItemAtIndex: function(index) {
     },
   };
 
   return {
     DeletableItemList: DeletableItemList,
     DeletableItem: DeletableItem,
   };
 });