Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 435463002: Enable rollback by default on trunk (m38). (Closed)

Created:
6 years, 4 months ago by haitaol1
Modified:
6 years, 4 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable rollback by default on trunk (m38). BUG=362679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287453

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -28 lines) Patch
M chrome/browser/sync/backup_rollback_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/backup_rollback_controller_unittest.cc View 4 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc View 5 chunks +4 lines, -8 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haitaol1
6 years, 4 months ago (2014-07-30 23:36:44 UTC) #1
Nicolas Zea
lgtm
6 years, 4 months ago (2014-07-31 17:46:54 UTC) #2
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 4 months ago (2014-07-31 18:28:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/435463002/40001
6 years, 4 months ago (2014-07-31 18:29:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-31 21:06:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 00:12:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/2017)
6 years, 4 months ago (2014-08-01 00:12:07 UTC) #7
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 4 months ago (2014-08-05 02:08:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/435463002/40001
6 years, 4 months ago (2014-08-05 02:09:28 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 04:54:38 UTC) #10
Message was sent while issue was closed. 
Change committed as 287453

Powered by Google App Engine
This is Rietveld 408576698