[ServiceWorker] Update formatting for tests.

[ServiceWorker] Update formatting for tests.

BUG=374802

[jsbell, 2014-07-31 20:37:23]

lgtm

https://codereview.chromium.org/435453002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/resources/interfaces.js (right):

https://codereview.chromium.org/435453002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/interfaces.js:1: function
verifyInterface(name, instance, attributes) {
We could rename this verify_interface... but then again, we should probably look
into using idlharness.js once we can use testharness.js in workers.

(I think Blink fails many idlharness tests due to crbug.com/43394, though, so
maybe not yet.)

https://codereview.chromium.org/435453002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/resources/test-helpers.js (right):

https://codereview.chromium.org/435453002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:12:
test.step_func(function(worker) { return Promise.resolve(worker); }),
Is this .then() clause necessary, or can we drop it and just have a .catch()

[asanka, 2014-08-01 05:15:52]

https://codereview.chromium.org/435453002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/resources/interfaces.js (right):

https://codereview.chromium.org/435453002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/interfaces.js:1: function
verifyInterface(name, instance, attributes) {
On 2014/07/31 20:37:23, jsbell wrote:
> We could rename this verify_interface... but then again, we should probably
look
> into using idlharness.js once we can use testharness.js in workers.
> 
> (I think Blink fails many idlharness tests due to crbug.com/43394, though, so
> maybe not yet.)

Good point. There are tests like this in w3c/web-platform-tests:
https://github.com/w3c/web-platform-tests/blob/master/service-workers/stub-4....

For now I renamed the function. I'll see if we can at least get it working for
serviceworker once the urgent tests are done.

https://codereview.chromium.org/435453002/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/resources/test-helpers.js (right):

https://codereview.chromium.org/435453002/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:12:
test.step_func(function(worker) { return Promise.resolve(worker); }),
On 2014/07/31 20:37:23, jsbell wrote:
> Is this .then() clause necessary, or can we drop it and just have a .catch()

Replaced with a .catch().then().catch() chain.

[falken, 2014-08-07 12:45:45]

https://codereview.chromium.org/435453002/diff/40001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/resources/test-helpers.js (right):

https://codereview.chromium.org/435453002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/test-helpers.js:22: var reason =
error.message || error.name || error;
Thank you for this!!! I've been using this locally and might end up checking it
in if a patch of mine lands before yours.

[falken, 2014-10-27 01:32:46]

falken@chromium.org changed reviewers:
- falken@chromium.org

[jsbell, 2014-10-27 18:26:30]

Still planning to land this?

[asanka, 2014-10-27 19:40:16]

On 2014/10/27 18:26:30, jsbell (TPAC Oct 27-28) wrote:
> Still planning to land this?

Needs to be updated, but yeah. Once the Cache.delete()/keys() stuff goes in.

I'll close it in the meantime and re-open once it's updated.