chrome/browser/resources/print_preview/settings/page_settings.js - Issue 435393005: [PrintPreview] Custom input focus toggles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/page_settings.js

Issue 435393005: [PrintPreview] Custom input focus toggles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/print_preview/settings/page_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/page_settings.js b/chrome/browser/resources/print_preview/settings/page_settings.js

index 6cec4e04d73c27b4fa3b494de7e1aa83b1a6ef6b..f9645444758468429c628bd85b49614e318745e3 100644

--- a/chrome/browser/resources/print_preview/settings/page_settings.js

+++ b/chrome/browser/resources/print_preview/settings/page_settings.js

@@ -170,8 +170,9 @@ cr.define('print_preview', function() {

* the custom input is empty.

* @private

- onCustomInputBlur_: function() {

- if (this.customInput_.value == '') {

+ onCustomInputBlur_: function(event) {

+ if (this.customInput_.value == '' &&

+ event.relatedTarget != this.customRadio_) {

this.allRadio_.checked = true;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »