[PrintPreview] Custom input focus toggles

chrome/browser/resources/print_preview/settings/page_settings.js

Index: chrome/browser/resources/print_preview/settings/page_settings.js
diff --git a/chrome/browser/resources/print_preview/settings/page_settings.js b/chrome/browser/resources/print_preview/settings/page_settings.js
index 6cec4e04d73c27b4fa3b494de7e1aa83b1a6ef6b..35547a483183b3c988fc9e4171678a4db83e1771 100644
--- a/chrome/browser/resources/print_preview/settings/page_settings.js
+++ b/chrome/browser/resources/print_preview/settings/page_settings.js
@@ -166,14 +166,10 @@ cr.define('print_preview', function() {
     },
 
     /**
-     * Called when the custom input is blurred. Enables the all radio button if
-     * the custom input is empty.
+     * Called when the custom input is blurred.
      * @private
      */
     onCustomInputBlur_: function() {

[Nikhil, 2014/08/05 14:39:40]

Do we need to keep this empty function?

[Aleksey Shlyapnikov, 2014/08/07 22:49:14]

It should not be empty, see my other comment.

[Nikhil, 2014/08/08 11:34:36]

Acknowledged.

-      if (this.customInput_.value == '') {

[Aleksey Shlyapnikov, 2014/08/07 22:49:14]

You're breaking the existing functionality, changing selection back to All when
no range is provided. You should check that control other than custom radio
button is focused, something like this:

if (this.customInput_.value == '' && e.relatedTarget != this.customRadio_)

[Nikhil, 2014/08/08 11:34:36]

Thanks for reviewing and catching this! I didn't know changing selection back to
All when no range is provided is required. I tried the solution that you
mentioned and it now works as intended.

When no range is provided, clicking custom radio button again doesn't cause
selection to toggle. And if we lose focus (for eg. right click somewhere) when
no range is provided, selection goes back to All.

PTAL. Thanks!

-        this.allRadio_.checked = true;
-      }
     },
 
     /**