ui/base/ui_base_switches.cc - Issue 435383002: adds WARP support to Chromium, for Metro mode only, on Windows 8

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/ui_base_switches.cc

Issue 435383002: adds WARP support to Chromium, for Metro mode only, on Windows 8 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: move kViewerConnect Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « ui/base/ui_base_switches.h ('k') | ui/gl/generate_bindings.py » ('j') | ui/gl/gl_surface_win.cc » ('J')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/base/ui_base_switches.h"	5 #include "ui/base/ui_base_switches.h"

6	6

7 namespace switches {	7 namespace switches {

8	8

9 #if defined(OS_MACOSX) && !defined(OS_IOS)	9 #if defined(OS_MACOSX) && !defined(OS_IOS)

10 // Enable use of cross-process CALayers to display content directly from the	10 // Enable use of cross-process CALayers to display content directly from the

(...skipping 26 matching lines...) Expand all Loading...
37 const char kEnableTouchEditing[] = "enable-touch-editing";	37 const char kEnableTouchEditing[] = "enable-touch-editing";

38	38

39 // The language file that we want to try to open. Of the form	39 // The language file that we want to try to open. Of the form

40 // language[-country] where language is the 2 letter code from ISO-639.	40 // language[-country] where language is the 2 letter code from ISO-639.

41 const char kLang[] = "lang";	41 const char kLang[] = "lang";

42	42

43 // Disable ui::MessageBox. This is useful when running as part of scripts that	43 // Disable ui::MessageBox. This is useful when running as part of scripts that

44 // do not have a user interface.	44 // do not have a user interface.

45 const char kNoMessageBox[] = "no-message-box";	45 const char kNoMessageBox[] = "no-message-box";

46	46

	47 // On Windows only: requests that Chrome connect to the running Metro viewer

	48 // process.

	49 const char kViewerConnect[] = "viewer-connect";
	Ken Russell (switch to Gerrit) 2014/09/02 23:57:29 This name is confusing; I'd suggest something like This name is confusing; I'd suggest something like --metro-viewer-connect or --connect-to-metro-viewer. luken 2014/09/03 00:58:07 Sure, cpu@ approves a change of name to this flag. Show quoted text On 2014/09/02 23:57:29, Ken Russell wrote: > This name is confusing; I'd suggest something like --metro-viewer-connect or > --connect-to-metro-viewer. Sure, cpu@ approves a change of name to this flag. Were you OK with the rename in the same CL that moves the flag (e.g. this one) or should I do that in a subsequent CL? luken 2014/09/03 20:59:30 Done. Show quoted text On 2014/09/03 00:58:07, luken wrote: > On 2014/09/02 23:57:29, Ken Russell wrote: > > This name is confusing; I'd suggest something like --metro-viewer-connect or > > --connect-to-metro-viewer. > > Sure, cpu@ approves a change of name to this flag. Were you OK with the rename > in the same CL that moves the flag (e.g. this one) or should I do that in a > subsequent CL? Done.
	50

47 } // namespace switches	51 } // namespace switches

OLD	NEW