Subzero: Fix and clean up some cross tests.

crosstest/test_vector_ops_main.cpp

Index: crosstest/test_vector_ops_main.cpp
diff --git a/crosstest/test_vector_ops_main.cpp b/crosstest/test_vector_ops_main.cpp
index f48e09903f59d8f787dc74ce46c519794faa89e6..f7700ddb211958a98aa6c334769bbbcff7e981b6 100644
--- a/crosstest/test_vector_ops_main.cpp
+++ b/crosstest/test_vector_ops_main.cpp
@@ -53,7 +53,7 @@ typename VectorOps<T>::Ty *getTestVectors(size_t &NumTestVectors) {
   const size_t VECTOR_ALIGNMENT = 16;
   void *Dest;
   if (posix_memalign(&Dest, VECTOR_ALIGNMENT, sizeof(TestVectors))) {
-    std::cerr << "memory allocation error" << std::endl;
+    std::cerr << "memory allocation error" << "\n";

[wala, 2014/08/05 05:16:34]

Nit: Could fold the last two string arguments to "memory allocation error\n".
Two adjacent string literals as stream arguments look somewhat unnecessary. LLVM
code seems to de facto prefer "...\n" or "..." << '\n'.

[Jim Stichnoth, 2014/08/06 16:14:26]

Thanks.  This was the result of blind search/replace, and I didn't notice the
redundancy.

     abort();
   }
 
@@ -89,9 +89,9 @@ void testInsertElement(size_t &TotalTests, size_t &Passes, size_t &Failures) {
           std::cout << "insertelement<" << VectorOps<T>::TypeName << ">(Vect=";
           std::cout << vectAsString<T>(Vect)
                     << ", Element=" << (typename VectorOps<T>::CastTy)Elt
-                    << ", Pos=" << I << ")" << std::endl;
-          std::cout << "llc=" << vectAsString<T>(ResultLlc) << std::endl;
-          std::cout << "sz =" << vectAsString<T>(ResultSz) << std::endl;
+                    << ", Pos=" << I << ")" << "\n";

[wala, 2014/08/05 05:16:34]

See above.

[Jim Stichnoth, 2014/08/06 16:14:26]

Done.

+          std::cout << "llc=" << vectAsString<T>(ResultLlc) << "\n";
+          std::cout << "sz =" << vectAsString<T>(ResultSz) << "\n";
         }
       }
     }
@@ -120,9 +120,9 @@ void testExtractElement(size_t &TotalTests, size_t &Passes, size_t &Failures) {
       } else {
         ++Failures;
         std::cout << "extractelement<" << VectorOps<T>::TypeName << ">(Vect=";
-        std::cout << vectAsString<T>(Vect) << ", Pos=" << I << ")" << std::endl;
-        std::cout << "llc=" << ResultLlc << std::endl;
-        std::cout << "sz =" << ResultSz << std::endl;
+        std::cout << vectAsString<T>(Vect) << ", Pos=" << I << ")" << "\n";

[wala, 2014/08/05 05:16:34]

See above.

[Jim Stichnoth, 2014/08/06 16:14:26]

Done.

+        std::cout << "llc=" << ResultLlc << "\n";
+        std::cout << "sz =" << ResultSz << "\n";
       }
     }
   }
@@ -166,7 +166,7 @@ int main(int argc, char *argv[]) {
 extern "C" {
 
 void ice_unreachable(void) {
-  std::cerr << "\"unreachable\" instruction encountered" << std::endl;
+  std::cerr << "\"unreachable\" instruction encountered" << "\n";

[wala, 2014/08/05 05:16:34]

See above.

[Jim Stichnoth, 2014/08/06 16:14:26]

Done.

   abort();
 }
 }