Subzero: Fix and clean up some cross tests.

Subzero: Fix and clean up some cross tests.

1. It turns out that the crosstest scripts mix different versions of
clang - build_pnacl_ir.py uses pnacl-clang from the NaCl SDK for the
tests, while crosstest.py uses clang/clang++ from LLVM_BIN_PATH for
the driver.  The SDK has been updated to use a different version of
the standard library, and now there is a mismatch as to whether int8_t
is typedef'd to 'char' or 'signed char', leading to name mangling
mismatches.  (char, signed char, and unsigned char are distinct
types.)  We deal with this by using myint8_t which is explicitly
defined as signed char.

2. Some ugly function pointer casting in test_arith_main.cpp is fixed/removed.

3. std::endl is replaced with "\n".

4. License text is added to tests that were touched by the above items.

BUG= none
R=wala@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7da431b

[wala, 2014-08-05 05:16:34]

lgtm

https://codereview.chromium.org/435353002/diff/1/crosstest/test_global.cpp
File crosstest/test_global.cpp (right):

https://codereview.chromium.org/435353002/diff/1/crosstest/test_global.cpp#ne...
crosstest/test_global.cpp:1: //===- subzero/crosstest/test_arith.cpp - Global
variable access tests ----===//
test_global.cpp

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
File crosstest/test_vector_ops_main.cpp (right):

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
crosstest/test_vector_ops_main.cpp:56: std::cerr << "memory allocation error" <<
"\n";
Nit: Could fold the last two string arguments to "memory allocation error\n".
Two adjacent string literals as stream arguments look somewhat unnecessary. LLVM
code seems to de facto prefer "...\n" or "..." << '\n'.

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
crosstest/test_vector_ops_main.cpp:92: << ", Pos=" << I << ")" << "\n";
See above.

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
crosstest/test_vector_ops_main.cpp:123: std::cout << vectAsString<T>(Vect) << ",
Pos=" << I << ")" << "\n";
See above.

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
crosstest/test_vector_ops_main.cpp:169: std::cerr << "\"unreachable\"
instruction encountered" << "\n";
See above.

[Jim Stichnoth, 2014-08-05 18:22:41]

Committed patchset #2 manually as r7da431b (presubmit successful).

[Jim Stichnoth, 2014-08-06 16:14:26]

https://codereview.chromium.org/435353002/diff/1/crosstest/test_global.cpp
File crosstest/test_global.cpp (right):

https://codereview.chromium.org/435353002/diff/1/crosstest/test_global.cpp#ne...
crosstest/test_global.cpp:1: //===- subzero/crosstest/test_arith.cpp - Global
variable access tests ----===//
On 2014/08/05 05:16:34, wala wrote:
> test_global.cpp

Done.

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
File crosstest/test_vector_ops_main.cpp (right):

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
crosstest/test_vector_ops_main.cpp:56: std::cerr << "memory allocation error" <<
"\n";
On 2014/08/05 05:16:34, wala wrote:
> Nit: Could fold the last two string arguments to "memory allocation error\n".
> Two adjacent string literals as stream arguments look somewhat unnecessary.
LLVM
> code seems to de facto prefer "...\n" or "..." << '\n'.

Thanks.  This was the result of blind search/replace, and I didn't notice the
redundancy.

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
crosstest/test_vector_ops_main.cpp:92: << ", Pos=" << I << ")" << "\n";
On 2014/08/05 05:16:34, wala wrote:
> See above.

Done.

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
crosstest/test_vector_ops_main.cpp:123: std::cout << vectAsString<T>(Vect) << ",
Pos=" << I << ")" << "\n";
On 2014/08/05 05:16:34, wala wrote:
> See above.

Done.

https://codereview.chromium.org/435353002/diff/1/crosstest/test_vector_ops_ma...
crosstest/test_vector_ops_main.cpp:169: std::cerr << "\"unreachable\"
instruction encountered" << "\n";
On 2014/08/05 05:16:34, wala wrote:
> See above.

Done.