Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 435343002: Move NaClModulesHandler to src/extensions (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move NaClModulesHandler to src/extensions This is a first, very small step towards making NaCl work in app_shell. BUG=400577 TEST=compiles TBR=brettw@chromium.org for moving a few lines out of chrome/common/BUILD.gn into extensions/common/BUILD.gn Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288136

Patch Set 1 #

Total comments: 2

Patch Set 2 : (manifest-handlers) move to common #

Patch Set 3 : (nacl-modules) rebase #

Patch Set 4 : (nacl-modules) rebase, fix gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -147 lines) Patch
M chrome/browser/extensions/plugin_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/BUILD.gn View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/nacl_modules_handler.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/nacl_modules_handler.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M extensions/common/BUILD.gn View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/common/common_manifest_handlers.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
A + extensions/common/manifest_handlers/nacl_modules_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/nacl_modules_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
James Cook
rockot, PTAL
6 years, 4 months ago (2014-08-04 23:34:00 UTC) #1
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/435343002/diff/1/chrome/common/extensions/chrome_manifest_handlers.cc File chrome/common/extensions/chrome_manifest_handlers.cc (right): https://codereview.chromium.org/435343002/diff/1/chrome/common/extensions/chrome_manifest_handlers.cc#newcode65 chrome/common/extensions/chrome_manifest_handlers.cc:65: (new NaClModulesHandler)->Register(); Any harm in moving this to ...
6 years, 4 months ago (2014-08-04 23:41:57 UTC) #2
James Cook
https://codereview.chromium.org/435343002/diff/1/chrome/common/extensions/chrome_manifest_handlers.cc File chrome/common/extensions/chrome_manifest_handlers.cc (right): https://codereview.chromium.org/435343002/diff/1/chrome/common/extensions/chrome_manifest_handlers.cc#newcode65 chrome/common/extensions/chrome_manifest_handlers.cc:65: (new NaClModulesHandler)->Register(); On 2014/08/04 23:41:56, Ken Rockot wrote: > ...
6 years, 4 months ago (2014-08-05 02:02:20 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-05 02:02:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/435343002/20001
6 years, 4 months ago (2014-08-05 02:04:27 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 06:19:47 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 06:44:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/2707)
6 years, 4 months ago (2014-08-05 06:44:06 UTC) #8
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-06 17:30:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/435343002/20001
6 years, 4 months ago (2014-08-06 17:32:00 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 17:35:33 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 17:38:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/3217)
6 years, 4 months ago (2014-08-06 17:38:34 UTC) #13
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-06 21:11:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/435343002/40001
6 years, 4 months ago (2014-08-06 21:13:32 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-07 01:44:28 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 02:09:47 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/4017)
6 years, 4 months ago (2014-08-07 02:09:50 UTC) #18
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 4 months ago (2014-08-07 16:44:16 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/435343002/60001
6 years, 4 months ago (2014-08-07 16:46:48 UTC) #20
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 20:40:14 UTC) #21
Message was sent while issue was closed.
Change committed as 288136

Powered by Google App Engine
This is Rietveld 408576698