Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 435333002: Remove in-process call to SetProcessBackgrounded. (Closed)

Created:
6 years, 4 months ago by Will Harris
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove in-process call to SetProcessBackgrounded. This was causing latency on switching tabs. BUG=398103, 381820 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/child/process_background_message_filter.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Will Harris
see the huge email thread for details on this. Basically the crashes were still at ...
6 years, 4 months ago (2014-08-04 23:23:45 UTC) #1
Will Harris
On 2014/08/04 23:23:45, Will Harris wrote: > see the huge email thread for details on ...
6 years, 4 months ago (2014-08-04 23:24:34 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-08-05 09:07:46 UTC) #3
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 4 months ago (2014-08-05 15:03:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/435333002/1
6 years, 4 months ago (2014-08-05 15:04:16 UTC) #5
commit-bot: I haz the power
Change committed as 287571
6 years, 4 months ago (2014-08-05 18:22:56 UTC) #6
jam
On 2014/08/04 23:24:34, Will Harris wrote: > On 2014/08/04 23:23:45, Will Harris wrote: > > ...
6 years, 4 months ago (2014-08-05 19:02:40 UTC) #7
Will Harris
6 years, 4 months ago (2014-08-05 19:04:53 UTC) #8
Message was sent while issue was closed.
On 2014/08/05 19:02:40, jam wrote:
> On 2014/08/04 23:24:34, Will Harris wrote:
> > On 2014/08/04 23:23:45, Will Harris wrote:
> > > see the huge email thread for details on this.  Basically the crashes were
> > still
> > > at around 3% with the call in, so I'm going to remove it until we have a
way
> > of
> > > measuring the impact of backgrounding this intensively.
> > 
> > I'm leaving the I/O thread vs main thread code in because it's likely that
any
> > fix we do to this code in future might still need the ability to call the
> > SetProcessBackgrounded from the I/O thread.
> 
> I think we should remove the unnecessary filter now. If you need it later,
it's
> trivial to bring it. no need to leave unused complexity in the code base.

okay I will prepare a CL to remove this filter.

Powered by Google App Engine
This is Rietveld 408576698