Valgrind: If running a specific list of layout tests, do not pass --run-chunk.

Valgrind: If running a specific list of layout tests, do not pass --run-chunk.

BUG=399964
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287812

[Dirk Pranke, 2014-08-04 23:48:07]

lgtm

[Timur Iskhodzhanov, 2014-08-05 09:28:01]

https://codereview.chromium.org/435313002/diff/1/tools/valgrind/chrome_tests.py
File tools/valgrind/chrome_tests.py (right):

https://codereview.chromium.org/435313002/diff/1/tools/valgrind/chrome_tests....
tools/valgrind/chrome_tests.py:515: assert((chunk_size == 0) != (len(self._args)
== 0))
This is gonna fire if you pass contradictory flags to chrome_tests.sh, right? 
If so, can we make this a check-with-print rather than assert?

[Lei Zhang, 2014-08-06 01:53:07]

https://codereview.chromium.org/435313002/diff/1/tools/valgrind/chrome_tests.py
File tools/valgrind/chrome_tests.py (right):

https://codereview.chromium.org/435313002/diff/1/tools/valgrind/chrome_tests....
tools/valgrind/chrome_tests.py:515: assert((chunk_size == 0) != (len(self._args)
== 0))
On 2014/08/05 09:28:01, Timur Iskhodzhanov wrote:
> This is gonna fire if you pass contradictory flags to chrome_tests.sh, right? 
> If so, can we make this a check-with-print rather than assert?

This only asserts if you pass "-n 0" without additional arguments. If one passes
arguments, it supersedes the -n switch.

[Timur Iskhodzhanov, 2014-08-06 13:21:19]

OK, LGTM if it works :)

[Lei Zhang, 2014-08-06 18:23:50]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-06 18:25:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/435313002/1

[commit-bot: I haz the power, 2014-08-06 18:37:08]

Change committed as 287812