Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 435303005: [win] Set the drag item visible when externally cancelling a drag in the app launcher (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

[win] Set the drag item visible when externally cancelling a drag in the app launcher When the nested message loop running a synchronous drag event on windows is cancelled due to an external event, it does not currently set the item visible again. Now it does. BUG=393519 TEST=Open a signed-in profile on two computers. On one computer, uninstall an app from the app launcher. Then, Quickly switch to the other computer and start dragging around a different app. When the sync event to uninstall the app comes in, the drag should cancel, with the item being dragged reappearing. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/app_list/views/apps_grid_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tapted
ben likes synchronous drag CLs :) Pretty sure this isn't one of those camel-breaking straw ...
6 years, 4 months ago (2014-08-05 01:45:36 UTC) #1
benwells
lgtm
6 years, 4 months ago (2014-08-05 03:39:55 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-08-05 03:51:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/435303005/1
6 years, 4 months ago (2014-08-05 03:53:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 04:58:58 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 08:27:43 UTC) #6
Message was sent while issue was closed.
Change committed as 287499

Powered by Google App Engine
This is Rietveld 408576698